From: Jonathan Corbet <corbet@lwn.net>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: peterz@infradead.org, mingo@redhat.com, will@kernel.org,
longman@redhat.com, boqun.feng@gmail.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Halaney <ahalaney@redhat.com>,
Leah Leshchinsky <lleshchi@redhat.com>
Subject: Re: [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh() description
Date: Fri, 04 Mar 2022 10:13:46 -0700 [thread overview]
Message-ID: <875yothc8l.fsf@meer.lwn.net> (raw)
In-Reply-To: <20220224212312.2601153-1-ahalaney@redhat.com>
Andrew Halaney <ahalaney@redhat.com> writes:
> With PREEMPT_RT the _bh() version of a spinlock leaves preemption
> enabled, align the doc to say that instead of the opposite.
>
> Reported-by: Leah Leshchinsky <lleshchi@redhat.com>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
> Documentation/locking/locktypes.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst
> index 4fd7b70fcde1..bfa75ea1b66a 100644
> --- a/Documentation/locking/locktypes.rst
> +++ b/Documentation/locking/locktypes.rst
> @@ -247,7 +247,7 @@ based on rt_mutex which changes the semantics:
> Non-PREEMPT_RT kernels disable preemption to get this effect.
>
> PREEMPT_RT kernels use a per-CPU lock for serialization which keeps
> - preemption disabled. The lock disables softirq handlers and also
> + preemption enabled. The lock disables softirq handlers and also
> prevents reentrancy due to task preemption.
Applied, thanks.
jon
prev parent reply other threads:[~2022-03-04 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 21:23 [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh() description Andrew Halaney
2022-02-25 2:22 ` Boqun Feng
2022-03-04 17:13 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yothc8l.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=ahalaney@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lleshchi@redhat.com \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).