From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17D3C433FE for ; Mon, 27 Sep 2021 17:50:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDEFD60F9B for ; Mon, 27 Sep 2021 17:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237876AbhI0Rvh (ORCPT ); Mon, 27 Sep 2021 13:51:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237507AbhI0Rve (ORCPT ); Mon, 27 Sep 2021 13:51:34 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 148E9C06120F; Mon, 27 Sep 2021 10:44:00 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:104d::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id B7CD8867; Mon, 27 Sep 2021 17:43:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net B7CD8867 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1632764639; bh=ZtnzvOYoJU2QJS7oSLw7U3mGblXZ6NQEMSpDfwmTgqI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aoZAgmTTMm5lD1s5kPvg9Lg1IqmLwITC4VJ6dW660IVZWU3CXlhQURHSKNVC73jwU iTQQJjUeigqOdycqBTJCHQwIOrwW+joEr5X8kTPU+56Tip3KWRTFu+Cc3wAA/pT1hA rWr+4kT3hWxD1CEyxAuFJk5vW6dAN3WZsU2ejMPf9ht/VehZ6GCh4NEiNfu2GmsAsp 5iOd3h5iutkzKQub0UREf38/PM587DMaf4j2KM4m7LhFcQhHlBtO5jdSONWwRhKKRe nICJYtxy5IxjcOt5zw/QqX/Aq1tdNCs95lyWOat9Ap8e0xrszhAVWE1IxtT5s3QLHZ 7N5WiD8epPsnw== From: Jonathan Corbet To: Utkarsh Verma , Dwaipayan Ray Cc: Lukas Bulwahn , Joe Perches , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Utkarsh Verma Subject: Re: [PATCH] Documentation: checkpatch: Document some more message types In-Reply-To: <20210925201746.15917-1-utkarshverma294@gmail.com> References: <20210925201746.15917-1-utkarshverma294@gmail.com> Date: Mon, 27 Sep 2021 11:43:59 -0600 Message-ID: <875yulj4m8.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Utkarsh Verma writes: > Added and documented 3 new message types: > - UNNECESSARY_INT > - UNSPECIFIED_INT > - UNNECESSARY_ELSE > > Signed-off-by: Utkarsh Verma > --- > Documentation/dev-tools/checkpatch.rst | 47 ++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) So...when you send multiple patches with the same subject line that's always a bad sign. We really want a "git --oneline" listing to give a good idea of what the patch does, and that depends on more descriptive subject lines. In this case, something like: docs: checkpatch: add UNNECESSARY/UNSPECIFIED_INT and UNNECESSARY_ELSE I can fix up these two patches, but please try to keep this in mind for future work. (applying the patches now). Thanks, jon