linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: pioneer695 <pioneer695@protonmail.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: make cleandocs issue: rm -rf /output when obj not defined
Date: Sun, 25 Jul 2021 14:11:49 -0600	[thread overview]
Message-ID: <875ywyw3ui.fsf@meer.lwn.net> (raw)
In-Reply-To: <hMV_L3bAsgmBToxsfiYBJDxTBoLHll-1BOk7FvqialjmZFNDp14Bq69ddTVagVH49yViCM43-yFpZ39Kfr6geVK7ota0QhCDA4MaC_5vILY=@protonmail.com>

pioneer695 <pioneer695@protonmail.com> writes:

> In an attempt to get some readable documentation I cloned the git repository
> to check how the PDF format is.
>
> Entered Documentation and proceeded with:
>
> 	make pdfdocs
>
> which failed, so to start fresh, my thought was that:
>
> 	make cleandocs
>
> would be the next step before anything else. But, this resulted in:
>
> 	rm -rf /output

That's not good...

> as $(obj) for some reason was empty.

*This* would appear to be the real problem.  If you could do some
digging to figure out why that happened, I suspect that would be
useful. 

> Makefile for Documentation has:
>
> 	BUILDDIR      = $(obj)/output
>
> 	cleandocs:
> 		$(Q)rm -rf $(BUILDDIR)
>
>
> This should (at least?!) be:
>
> 	BUILDDIR      = ./$(obj)/output
> or:
> 	$(Q)rm -rf ./$(BUILDDIR)

These would break builds for a lot of people and are not the right
solution.

Thanks for the report,

jon

  reply	other threads:[~2021-07-25 20:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24 19:56 make cleandocs issue: rm -rf /output when obj not defined pioneer695
2021-07-25 20:11 ` Jonathan Corbet [this message]
2021-07-25 20:53   ` Randy Dunlap
2021-07-27 11:25     ` Matthew Wilcox
2021-08-17 21:23     ` pioneer695

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ywyw3ui.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=pioneer695@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).