* [PATCH v2] usb: gadget: fix max_segment_size malformed table
@ 2024-01-28 4:53 Randy Dunlap
2024-01-30 21:12 ` Jonathan Corbet
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2024-01-28 4:53 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Krishna Kurapati, Greg Kroah-Hartman, linux-usb,
Jonathan Corbet, linux-doc, Sergei Shtylyov
Sphinx reports a malformed table due to the table begin/end line
segments being too short for the word "max_segment_size", so
extend them by one more '=' character to prevent the error.
Documentation/usb/gadget-testing.rst:459: ERROR: Malformed table.
Text in column margin in table line 9.
Fixes: 1900daeefd3e ("usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Krishna Kurapati <quic_kriskura@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>
---
v2: s /to error/the error/ in the patch description.
Documentation/usb/gadget-testing.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -- a/Documentation/usb/gadget-testing.rst b/Documentation/usb/gadget-testing.rst
--- a/Documentation/usb/gadget-testing.rst
+++ b/Documentation/usb/gadget-testing.rst
@@ -448,7 +448,7 @@ Function-specific configfs interface
The function name to use when creating the function directory is "ncm".
The NCM function provides these attributes in its function directory:
- =============== ==================================================
+ ================ ==================================================
ifname network device interface name associated with this
function instance
qmult queue length multiplier for high and super speed
@@ -458,7 +458,7 @@ The NCM function provides these attribut
Ethernet over USB link
max_segment_size Segment size required for P2P connections. This
will set MTU to (max_segment_size - 14 bytes)
- =============== ==================================================
+ ================ ==================================================
and after creating the functions/ncm.<instance name> they contain default
values: qmult is 5, dev_addr and host_addr are randomly selected.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] usb: gadget: fix max_segment_size malformed table
2024-01-28 4:53 [PATCH v2] usb: gadget: fix max_segment_size malformed table Randy Dunlap
@ 2024-01-30 21:12 ` Jonathan Corbet
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2024-01-30 21:12 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Randy Dunlap, Krishna Kurapati, Greg Kroah-Hartman, linux-usb,
linux-doc, Sergei Shtylyov
Randy Dunlap <rdunlap@infradead.org> writes:
> Sphinx reports a malformed table due to the table begin/end line
> segments being too short for the word "max_segment_size", so
> extend them by one more '=' character to prevent the error.
>
> Documentation/usb/gadget-testing.rst:459: ERROR: Malformed table.
> Text in column margin in table line 9.
>
> Fixes: 1900daeefd3e ("usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Krishna Kurapati <quic_kriskura@quicinc.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>
> ---
> v2: s /to error/the error/ in the patch description.
>
> Documentation/usb/gadget-testing.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-30 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-28 4:53 [PATCH v2] usb: gadget: fix max_segment_size malformed table Randy Dunlap
2024-01-30 21:12 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).