From: Cornelia Huck <cohuck@redhat.com>
To: "Bagas Sanjaya" <bagasdotme@gmail.com>,
"Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: linux-doc@vger.kernel.org, corbet@lwn.net, mst@redhat.com,
virtualization@lists.linux-foundation.org, jasowang@redhat.com,
kernel@collabora.com
Subject: Re: [RESEND PATCH v5 1/1] docs: driver-api: virtio: virtio on Linux
Date: Mon, 10 Oct 2022 15:43:46 +0200 [thread overview]
Message-ID: <877d17n699.fsf@redhat.com> (raw)
In-Reply-To: <Y0QYTq7KW9C731s0@debian.me>
On Mon, Oct 10 2022, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> On Mon, Oct 10, 2022 at 08:43:59AM +0200, Ricardo Cañuelo wrote:
>> +
>> +References
>> +==========
>> +
>> +_`[1]` Virtio Spec v1.2:
>> +https://docs.oasis-open.org/virtio/virtio/v1.2/virtio-v1.2.html
>> +
>> +Check for later versions of the spec as well.
>> +
>
> The version checking should be made comment (not visible on the output):
>
> ---- >8 ----
> diff --git a/Documentation/driver-api/virtio/virtio.rst b/Documentation/driver-api/virtio/virtio.rst
> index 70b3aa6bcf5518..4f3abbec4e8b2c 100644
> --- a/Documentation/driver-api/virtio/virtio.rst
> +++ b/Documentation/driver-api/virtio/virtio.rst
> @@ -134,7 +134,7 @@ References
> _`[1]` Virtio Spec v1.2:
> https://docs.oasis-open.org/virtio/virtio/v1.2/virtio-v1.2.html
>
> -Check for later versions of the spec as well.
> +.. Check for later versions of the spec as well.
>
> _`[2]` Virtqueues and virtio ring: How the data travels
> https://www.redhat.com/en/blog/virtqueues-and-virtio-ring-how-data-travels
>
>> diff --git a/Documentation/driver-api/virtio/writing_virtio_drivers.rst b/Documentation/driver-api/virtio/writing_virtio_drivers.rst
>> new file mode 100644
>> index 000000000000..e14c58796d25
>> --- /dev/null
>> +++ b/Documentation/driver-api/virtio/writing_virtio_drivers.rst
>> <snipped>...
>> +References
>> +==========
>> +
>> +_`[1]` Virtio Spec v1.2:
>> +https://docs.oasis-open.org/virtio/virtio/v1.2/virtio-v1.2.html
>> +
>> +Check for later versions of the spec as well.
>
> Same reply.
I don't think we should hide that in a comment -- unless you want to
update this file every time a new version of the virtio spec gets
released.
next prev parent reply other threads:[~2022-10-10 13:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 6:43 [RESEND PATCH v5 0/1] docs: driver-api: virtio: virtio on Linux Ricardo Cañuelo
2022-10-10 6:43 ` [RESEND PATCH v5 1/1] " Ricardo Cañuelo
2022-10-10 13:04 ` Bagas Sanjaya
2022-10-10 13:43 ` Cornelia Huck [this message]
2022-10-10 17:11 ` Michael S. Tsirkin
2022-10-11 6:51 ` Cornelia Huck
2022-10-11 7:20 ` Bagas Sanjaya
2022-10-11 7:57 ` Cornelia Huck
2022-10-11 8:30 ` Bagas Sanjaya
2022-10-11 8:46 ` Ricardo Cañuelo
2022-12-19 6:20 ` Michael S. Tsirkin
2022-12-19 8:38 ` Bagas Sanjaya
2022-12-19 10:53 ` Michael S. Tsirkin
2022-12-20 8:13 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d17n699.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=jasowang@redhat.com \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ricardo.canuelo@collabora.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).