From: Takashi Iwai <tiwai@suse.de>
To: Rong Zhang <i@rong.moe>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Cryolitia PukNgae <cryolitia@uniontech.com>,
Arun Raghavan <arunr@valvesoftware.com>,
linux-sound@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Icenowy Zheng <uwu@icenowy.me>,
Terry Junge <linuxsound@cosmicgizmosystems.com>
Subject: Re: [PATCH] ALSA: usb-audio: Refine string-descriptor-based quirk matching
Date: Thu, 05 Mar 2026 20:49:56 +0100 [thread overview]
Message-ID: <87a4wmvyxn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260305174711.1106324-1-i@rong.moe>
On Thu, 05 Mar 2026 18:46:39 +0100,
Rong Zhang wrote:
>
> Remove snd_usb_get_string() and use the manufacturer and product strings
> stored in struct usb_device directly to match quirk table entries. Their
> NULLity can be checked to determine if the device has no these strings.
> This simplifies the code a lot.
>
> Meanwhile, allow quirk table entries to match "no string" explicitly, and
> add appropriate comments to show the expected usages of
> DEVICE_STRING_FLG() and VENDOR_STRING_FLG(). These changes are tiny and
> doesn't form another separate patch, so that back-and-forth changes can
> be avoided.
>
> Suggested-by: Terry Junge <linuxsound@cosmicgizmosystems.com>
> Link: https://lore.kernel.org/r/b59da54a-9c80-4212-a337-c5ea98da52d1@cosmicgizmosystems.com
> Signed-off-by: Rong Zhang <i@rong.moe>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2026-03-05 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 17:46 [PATCH] ALSA: usb-audio: Refine string-descriptor-based quirk matching Rong Zhang
2026-03-05 19:49 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4wmvyxn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=arunr@valvesoftware.com \
--cc=corbet@lwn.net \
--cc=cryolitia@uniontech.com \
--cc=i@rong.moe \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxsound@cosmicgizmosystems.com \
--cc=perex@perex.cz \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox