Linux Documentation
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Vegard Nossum <vegard.nossum@oracle.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-doc@vger.kernel.org, Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: [PATCH] Documentation: constrain alabaster package to older versions
Date: Wed, 10 Jan 2024 08:01:22 -0700	[thread overview]
Message-ID: <87a5pdqlkt.fsf@meer.lwn.net> (raw)
In-Reply-To: <20240110104646.3647600-1-vegard.nossum@oracle.com>

Vegard Nossum <vegard.nossum@oracle.com> writes:

> The 'alabaster' theme dropped support for Sphinx < v3.4:
>
>     0.7.14 – 2024-01-08
>
>     * Dropped support for Python 3.8 and earlier.
>     * Dropped support for Sphinx 3.3 and earlier.
>     [...]
>
> (Source: https://alabaster.readthedocs.io/en/latest/changelog.html)
>
> This manifests as an error when running 'make htmldocs' in a virtualenv
> constructed from Documentation/sphinx/requirements.txt:
>
>     Sphinx version error:
>     The alabaster extension used by this project needs at least Sphinx v3.4; it therefore cannot be built with this version.
>
> Raising the Sphinx version is not really a good option at this point,
> since 3.x through 6.x have horrible performance regressions (7.x still
> does, but not quite as bad).
>
> Instead, constrain the 'alabaster' package to versions that still support
> Sphinx 2.4.4.
>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> ---
>  Documentation/sphinx/requirements.txt | 2 ++
>  1 file changed, 2 insertions(+)

So this is a little strange, actually.  Alabaster is bundled with
Sphinx, so there should always be a version that works; I'm not sure why
we have it separately in the requirements.txt file (which is
discouraging, given that I probably put it there).

I'll try to look at this (but not right away); do you have any sense for
whether things work properly if that line is just taken out?

Thanks,

jon

  reply	other threads:[~2024-01-10 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 10:46 [PATCH] Documentation: constrain alabaster package to older versions Vegard Nossum
2024-01-10 15:01 ` Jonathan Corbet [this message]
2024-01-10 15:24   ` Jonathan Corbet
2024-01-10 15:24   ` Vegard Nossum
2024-01-11 14:05 ` Bagas Sanjaya
2024-01-11 16:17 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5pdqlkt.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox