From: Jonathan Corbet <corbet@lwn.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-doc@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] scripts/kernel-doc: support EXPORT_SYMBOL_NS_GPL() with -export
Date: Wed, 09 Nov 2022 07:28:43 -0700 [thread overview]
Message-ID: <87a650nqw4.fsf@meer.lwn.net> (raw)
In-Reply-To: <8338c944-f1af-7c86-f50d-09a07dc2beb7@gmail.com>
Bagas Sanjaya <bagasdotme@gmail.com> writes:
>> -Specify an additional FILE in which to look for EXPORT_SYMBOL() and
>> -EXPORT_SYMBOL_GPL().
>> +Specify an additional FILE in which to look for EXPORT_SYMBOL information.
>>
>
> For consistency, what about "Specify an additional FILE in which to look for
> EXPORT_SYMBOL() and related macros."
Nobody runs kernel-doc by hand except for a few of us trying to figure
out some weirdness. We really don't need nit-picking here. Please (for
the Nth time) stop adding unnecessary friction for our contributors.
> Anyway, what are EXPORT_SYMBOL_NS{,_GPL}() macros?
Somebody who tries to come across as the authoritative master of patch
style should know that. Maybe try reading the docs? :)
jon
prev parent reply other threads:[~2022-11-09 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 15:02 [PATCH] scripts/kernel-doc: support EXPORT_SYMBOL_NS_GPL() with -export Jason Gunthorpe
2022-11-08 15:25 ` Matthew Wilcox
2022-11-08 16:21 ` Jason Gunthorpe
2022-11-08 17:13 ` Matthew Wilcox
2022-11-08 17:24 ` Jason Gunthorpe
2022-11-09 8:24 ` Bagas Sanjaya
2022-11-09 14:28 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a650nqw4.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=bagasdotme@gmail.com \
--cc=jgg@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).