Re: [PATCH v2] Rework the jobserver open logic

[Jonathan Corbet <corbet@lwn.net>]

duchangbin <changbin.du@huawei.com> writes:

>> +def warn(text):
>> +    print(text, file = sys.stderr)
> Maybe this could be:
>        print(f"WARNING: {text}", file = sys.stderr)
> to unify the warnning messages.

Yes, that makes sense.

>> +        split_opt = opts[-1].split('=', 1)
>> +        if len(split_opt) != 2:
>> +            warn('WARNING: unparseable option:', opts[-1])
> Calling the warn() function with two positional arguments, but the function is
> defined to accept only one.

So that is embarrassing.  As penance I have now actually tested the
warning paths...

>> +            return
>> +        fds = split_opt[1]
>> +        #
>> +        # As of GNU Make 4.4, we'll be looking for a named pipe
>> +        # identified as fifo:path
>> +        #
>> +        if fds.startswith('fifo:'):
>> +            path = fds[len('fifo:':]
> Missing a parenthesis.
>                path = fds[len('fifo:'):]

...and that is even moreso.  I *did* test this before committing it, but
that obviously could never have gotten past the parsing phase.  I have
no idea what happened here.

Thanks for taking a look, new version coming shortly.

jon