From: Jonathan Corbet <corbet@lwn.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>, linux-doc@vger.kernel.org
Cc: Bagas Sanjaya <bagasdotme@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Add leds-qcom-lpg entry to documentation table of contents
Date: Fri, 03 Jun 2022 07:42:33 -0600 [thread overview]
Message-ID: <87bkv9x3qu.fsf@meer.lwn.net> (raw)
In-Reply-To: <20220603025735.17953-1-bagasdotme@gmail.com>
Bagas Sanjaya <bagasdotme@gmail.com> writes:
> After merging linux-leds tree to the mainline [1], htmldocs build produces
> a new warning:
>
> checking consistency... /home/bagas/repo/linux-stable/Documentation/leds/leds-qcom-lpg.rst: WARNING: document isn't included in any toctree
>
> The warning above is because leds-qcom-lpg.rst is missing in the table of
> contents.
>
> Add the missing entry.
The fix is good but ...
> [1]: https://lore.kernel.org/all/20220531200619.GA8906@duo.ucw.cz/
>
> Fixes: e98a860f65428a ("leds: qcom-lpg: Require pattern to follow documentation")
...I'm confused as to why you used that commit for a Fixes: tag. It
touched the file in question but didn't add it in the first place; I
think 24e2d05d1b68 is the droid you're looking for.
jon
next prev parent reply other threads:[~2022-06-03 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 2:57 [PATCH] leds: Add leds-qcom-lpg entry to documentation table of contents Bagas Sanjaya
2022-06-03 13:42 ` Jonathan Corbet [this message]
2022-06-03 13:53 ` Pavel Machek
2022-06-04 1:31 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkv9x3qu.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=bagasdotme@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).