From: Jonathan Corbet <corbet@lwn.net>
To: Abdul Rahim <abdul.rahim@myyahoo.com>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
abdul.rahim@myyahoo.com
Subject: Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst
Date: Fri, 06 Sep 2024 12:53:18 -0600 [thread overview]
Message-ID: <87cylgehr5.fsf@trenco.lwn.net> (raw)
In-Reply-To: <i432epqedna43bnow5twmm7bdf7dlms54kt5xjewalf5koamks@6kn4bx5lrubz>
Abdul Rahim <abdul.rahim@myyahoo.com> writes:
> On Fri, Sep 06, 2024 at 11:41:52AM GMT, Bjorn Helgaas wrote:
>> On Fri, Sep 06, 2024 at 06:15:18PM +0530, Abdul Rahim wrote:
>> > Fixed spelling and edited for clarity.
>> >
>> > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com>
>> > ---
>> > Documentation/PCI/pci.rst | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst
>> > index dd7b1c0c21da..344c2c2d94f9 100644
>> > --- a/Documentation/PCI/pci.rst
>> > +++ b/Documentation/PCI/pci.rst
>> > @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization:
>> > - Enable DMA/processing engines
>> >
>> > When done using the device, and perhaps the module needs to be unloaded,
>> > -the driver needs to take the follow steps:
>> > +the driver needs to perform the following steps:
>>
>> I don't see a spelling fix here, and personally I wouldn't bother with
>> changing "take" to "perform" unless we have other more significant
>> changes to make at the same time.
>
> - "follow" has been corrected to "following", which is more appriopriate
> in this context.
> - I know its trivial, but can disturb the readers flow
> - do you want me to change the message to "Edited for clarity"
The problem is not s/follow/following/, it is the other, unrelated
change you made that does not improve the text. There are reasons why
we ask people not to mix multiple changes. If you submit just the
"following" fix, it will surely be applied.
Thanks,
jon
next prev parent reply other threads:[~2024-09-06 18:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240906124518.10308-1-abdul.rahim.ref@myyahoo.com>
2024-09-06 12:45 ` [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst Abdul Rahim
2024-09-06 16:41 ` Bjorn Helgaas
2024-09-06 17:34 ` Abdul Rahim
2024-09-06 18:53 ` Jonathan Corbet [this message]
2024-09-06 19:14 ` Abdul Rahim
2024-09-06 19:24 ` Bjorn Helgaas
2024-09-07 10:11 ` Abdul Rahim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cylgehr5.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=abdul.rahim@myyahoo.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).