* [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst [not found] <20240906124518.10308-1-abdul.rahim.ref@myyahoo.com> @ 2024-09-06 12:45 ` Abdul Rahim 2024-09-06 16:41 ` Bjorn Helgaas 0 siblings, 1 reply; 7+ messages in thread From: Abdul Rahim @ 2024-09-06 12:45 UTC (permalink / raw) To: corbet, bhelgaas; +Cc: linux-kernel, linux-pci, linux-doc, Abdul Rahim Fixed spelling and edited for clarity. Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> --- Documentation/PCI/pci.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst index dd7b1c0c21da..344c2c2d94f9 100644 --- a/Documentation/PCI/pci.rst +++ b/Documentation/PCI/pci.rst @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization: - Enable DMA/processing engines When done using the device, and perhaps the module needs to be unloaded, -the driver needs to take the follow steps: +the driver needs to perform the following steps: - Disable the device from generating IRQs - Release the IRQ (free_irq()) -- 2.46.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst 2024-09-06 12:45 ` [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst Abdul Rahim @ 2024-09-06 16:41 ` Bjorn Helgaas 2024-09-06 17:34 ` Abdul Rahim 0 siblings, 1 reply; 7+ messages in thread From: Bjorn Helgaas @ 2024-09-06 16:41 UTC (permalink / raw) To: Abdul Rahim; +Cc: corbet, bhelgaas, linux-kernel, linux-pci, linux-doc On Fri, Sep 06, 2024 at 06:15:18PM +0530, Abdul Rahim wrote: > Fixed spelling and edited for clarity. > > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> > --- > Documentation/PCI/pci.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst > index dd7b1c0c21da..344c2c2d94f9 100644 > --- a/Documentation/PCI/pci.rst > +++ b/Documentation/PCI/pci.rst > @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization: > - Enable DMA/processing engines > > When done using the device, and perhaps the module needs to be unloaded, > -the driver needs to take the follow steps: > +the driver needs to perform the following steps: I don't see a spelling fix here, and personally I wouldn't bother with changing "take" to "perform" unless we have other more significant changes to make at the same time. > - Disable the device from generating IRQs > - Release the IRQ (free_irq()) > -- > 2.46.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst 2024-09-06 16:41 ` Bjorn Helgaas @ 2024-09-06 17:34 ` Abdul Rahim 2024-09-06 18:53 ` Jonathan Corbet 0 siblings, 1 reply; 7+ messages in thread From: Abdul Rahim @ 2024-09-06 17:34 UTC (permalink / raw) To: Bjorn Helgaas Cc: corbet, bhelgaas, linux-kernel, linux-pci, linux-doc, abdul.rahim On Fri, Sep 06, 2024 at 11:41:52AM GMT, Bjorn Helgaas wrote: > On Fri, Sep 06, 2024 at 06:15:18PM +0530, Abdul Rahim wrote: > > Fixed spelling and edited for clarity. > > > > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> > > --- > > Documentation/PCI/pci.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst > > index dd7b1c0c21da..344c2c2d94f9 100644 > > --- a/Documentation/PCI/pci.rst > > +++ b/Documentation/PCI/pci.rst > > @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization: > > - Enable DMA/processing engines > > > > When done using the device, and perhaps the module needs to be unloaded, > > -the driver needs to take the follow steps: > > +the driver needs to perform the following steps: > > I don't see a spelling fix here, and personally I wouldn't bother with > changing "take" to "perform" unless we have other more significant > changes to make at the same time. - "follow" has been corrected to "following", which is more appriopriate in this context. - I know its trivial, but can disturb the readers flow - do you want me to change the message to "Edited for clarity" ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst 2024-09-06 17:34 ` Abdul Rahim @ 2024-09-06 18:53 ` Jonathan Corbet 2024-09-06 19:14 ` Abdul Rahim 0 siblings, 1 reply; 7+ messages in thread From: Jonathan Corbet @ 2024-09-06 18:53 UTC (permalink / raw) To: Abdul Rahim, Bjorn Helgaas Cc: bhelgaas, linux-kernel, linux-pci, linux-doc, abdul.rahim Abdul Rahim <abdul.rahim@myyahoo.com> writes: > On Fri, Sep 06, 2024 at 11:41:52AM GMT, Bjorn Helgaas wrote: >> On Fri, Sep 06, 2024 at 06:15:18PM +0530, Abdul Rahim wrote: >> > Fixed spelling and edited for clarity. >> > >> > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> >> > --- >> > Documentation/PCI/pci.rst | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst >> > index dd7b1c0c21da..344c2c2d94f9 100644 >> > --- a/Documentation/PCI/pci.rst >> > +++ b/Documentation/PCI/pci.rst >> > @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization: >> > - Enable DMA/processing engines >> > >> > When done using the device, and perhaps the module needs to be unloaded, >> > -the driver needs to take the follow steps: >> > +the driver needs to perform the following steps: >> >> I don't see a spelling fix here, and personally I wouldn't bother with >> changing "take" to "perform" unless we have other more significant >> changes to make at the same time. > > - "follow" has been corrected to "following", which is more appriopriate > in this context. > - I know its trivial, but can disturb the readers flow > - do you want me to change the message to "Edited for clarity" The problem is not s/follow/following/, it is the other, unrelated change you made that does not improve the text. There are reasons why we ask people not to mix multiple changes. If you submit just the "following" fix, it will surely be applied. Thanks, jon ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst 2024-09-06 18:53 ` Jonathan Corbet @ 2024-09-06 19:14 ` Abdul Rahim 2024-09-06 19:24 ` Bjorn Helgaas 0 siblings, 1 reply; 7+ messages in thread From: Abdul Rahim @ 2024-09-06 19:14 UTC (permalink / raw) To: Jonathan Corbet Cc: Bjorn Helgaas, bhelgaas, linux-kernel, linux-pci, linux-doc On Fri, Sep 06, 2024 at 12:53:18PM GMT, Jonathan Corbet wrote: > Abdul Rahim <abdul.rahim@myyahoo.com> writes: > > > On Fri, Sep 06, 2024 at 11:41:52AM GMT, Bjorn Helgaas wrote: > >> On Fri, Sep 06, 2024 at 06:15:18PM +0530, Abdul Rahim wrote: > >> > Fixed spelling and edited for clarity. > >> > > >> > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> > >> > --- > >> > Documentation/PCI/pci.rst | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst > >> > index dd7b1c0c21da..344c2c2d94f9 100644 > >> > --- a/Documentation/PCI/pci.rst > >> > +++ b/Documentation/PCI/pci.rst > >> > @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization: > >> > - Enable DMA/processing engines > >> > > >> > When done using the device, and perhaps the module needs to be unloaded, > >> > -the driver needs to take the follow steps: > >> > +the driver needs to perform the following steps: > >> > >> I don't see a spelling fix here, and personally I wouldn't bother with > >> changing "take" to "perform" unless we have other more significant > >> changes to make at the same time. > > > > - "follow" has been corrected to "following", which is more appriopriate > > in this context. > > - I know its trivial, but can disturb the readers flow > > - do you want me to change the message to "Edited for clarity" > > The problem is not s/follow/following/, it is the other, unrelated > change you made that does not improve the text. There are reasons why > we ask people not to mix multiple changes. If you submit just the > "following" fix, it will surely be applied. > > Thanks, > > jon Understood, will take care next time. I will resend this patch with: "follow" -> "following", with commit message "Fixed spelling" ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst 2024-09-06 19:14 ` Abdul Rahim @ 2024-09-06 19:24 ` Bjorn Helgaas 2024-09-07 10:11 ` Abdul Rahim 0 siblings, 1 reply; 7+ messages in thread From: Bjorn Helgaas @ 2024-09-06 19:24 UTC (permalink / raw) To: Abdul Rahim; +Cc: Jonathan Corbet, bhelgaas, linux-kernel, linux-pci, linux-doc On Sat, Sep 07, 2024 at 12:44:13AM +0530, Abdul Rahim wrote: > On Fri, Sep 06, 2024 at 12:53:18PM GMT, Jonathan Corbet wrote: > > Abdul Rahim <abdul.rahim@myyahoo.com> writes: > > > > > On Fri, Sep 06, 2024 at 11:41:52AM GMT, Bjorn Helgaas wrote: > > >> On Fri, Sep 06, 2024 at 06:15:18PM +0530, Abdul Rahim wrote: > > >> > Fixed spelling and edited for clarity. > > >> > > > >> > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> > > >> > --- > > >> > Documentation/PCI/pci.rst | 2 +- > > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > > >> > diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst > > >> > index dd7b1c0c21da..344c2c2d94f9 100644 > > >> > --- a/Documentation/PCI/pci.rst > > >> > +++ b/Documentation/PCI/pci.rst > > >> > @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization: > > >> > - Enable DMA/processing engines > > >> > > > >> > When done using the device, and perhaps the module needs to be unloaded, > > >> > -the driver needs to take the follow steps: > > >> > +the driver needs to perform the following steps: > > >> > > >> I don't see a spelling fix here, and personally I wouldn't bother with > > >> changing "take" to "perform" unless we have other more significant > > >> changes to make at the same time. > > > > > > - "follow" has been corrected to "following", which is more appriopriate > > > in this context. > > > - I know its trivial, but can disturb the readers flow > > > - do you want me to change the message to "Edited for clarity" > > > > The problem is not s/follow/following/, it is the other, unrelated > > change you made that does not improve the text. There are reasons why > > we ask people not to mix multiple changes. If you submit just the > > "following" fix, it will surely be applied. > > Understood, will take care next time. I will resend this patch with: > "follow" -> "following", with commit message "Fixed spelling" Sorry I missed the "follow" change, which is indeed worth fixing. If you resend it, make your subject and commit log say "fix" (not "fixed"), like it's a command. https://chris.beams.io/posts/git-commit/ https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst?id=v6.9#n134 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst 2024-09-06 19:24 ` Bjorn Helgaas @ 2024-09-07 10:11 ` Abdul Rahim 0 siblings, 0 replies; 7+ messages in thread From: Abdul Rahim @ 2024-09-07 10:11 UTC (permalink / raw) To: Bjorn Helgaas Cc: Jonathan Corbet, bhelgaas, linux-kernel, linux-pci, linux-doc On Fri, Sep 06, 2024 at 02:24:29PM GMT, Bjorn Helgaas wrote: > On Sat, Sep 07, 2024 at 12:44:13AM +0530, Abdul Rahim wrote: > > On Fri, Sep 06, 2024 at 12:53:18PM GMT, Jonathan Corbet wrote: > > > Abdul Rahim <abdul.rahim@myyahoo.com> writes: > > > > > > > On Fri, Sep 06, 2024 at 11:41:52AM GMT, Bjorn Helgaas wrote: > > > >> On Fri, Sep 06, 2024 at 06:15:18PM +0530, Abdul Rahim wrote: > > > >> > Fixed spelling and edited for clarity. > > > >> > > > > >> > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> > > > >> > --- > > > >> > Documentation/PCI/pci.rst | 2 +- > > > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >> > > > > >> > diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst > > > >> > index dd7b1c0c21da..344c2c2d94f9 100644 > > > >> > --- a/Documentation/PCI/pci.rst > > > >> > +++ b/Documentation/PCI/pci.rst > > > >> > @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization: > > > >> > - Enable DMA/processing engines > > > >> > > > > >> > When done using the device, and perhaps the module needs to be unloaded, > > > >> > -the driver needs to take the follow steps: > > > >> > +the driver needs to perform the following steps: > > > >> > > > >> I don't see a spelling fix here, and personally I wouldn't bother with > > > >> changing "take" to "perform" unless we have other more significant > > > >> changes to make at the same time. > > > > > > > > - "follow" has been corrected to "following", which is more appriopriate > > > > in this context. > > > > - I know its trivial, but can disturb the readers flow > > > > - do you want me to change the message to "Edited for clarity" > > > > > > The problem is not s/follow/following/, it is the other, unrelated > > > change you made that does not improve the text. There are reasons why > > > we ask people not to mix multiple changes. If you submit just the > > > "following" fix, it will surely be applied. > > > > Understood, will take care next time. I will resend this patch with: > > "follow" -> "following", with commit message "Fixed spelling" > > Sorry I missed the "follow" change, which is indeed worth fixing. If > you resend it, make your subject and commit log say "fix" (not > "fixed"), like it's a command. > > https://chris.beams.io/posts/git-commit/ > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst?id=v6.9#n134 > Thanks for reviewing, i've resent this patch here: https://lore.kernel.org/lkml/20240906205656.8261-1-abdul.rahim@myyahoo.com/ ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-09-07 10:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240906124518.10308-1-abdul.rahim.ref@myyahoo.com>
2024-09-06 12:45 ` [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst Abdul Rahim
2024-09-06 16:41 ` Bjorn Helgaas
2024-09-06 17:34 ` Abdul Rahim
2024-09-06 18:53 ` Jonathan Corbet
2024-09-06 19:14 ` Abdul Rahim
2024-09-06 19:24 ` Bjorn Helgaas
2024-09-07 10:11 ` Abdul Rahim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).