From: Jonathan Corbet <corbet@lwn.net>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>, linux-doc@vger.kernel.org
Cc: Rae Moar <rmoar@google.com>
Subject: Re: [PATCH] kernel-doc: Allow whitespace before comment start
Date: Fri, 06 Sep 2024 07:49:13 -0600 [thread overview]
Message-ID: <87cylggaee.fsf@trenco.lwn.net> (raw)
In-Reply-To: <d780dfd8-79fb-4b4c-8764-bb18d32e98c2@intel.com>
Michal Wajdeczko <michal.wajdeczko@intel.com> writes:
> Oops, I'm pretty sure that I tried, but likely didn't rerun on fresh
> tree, so seen just changes resulted from adding visibility.h
>
> Sorry about that.
>
> But looking now at those new errors/warnings and IMO it seems that all
> of them are valid, mostly due to mistakes with formatting of the
> comments, not that tool is now broken.
>
>
> Few examples:
>
> ../kernel/resource.c:148: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * If the resource was allocated using memblock early during
>
> 145 static void free_resource(struct resource *res)
> 146 {
> 147 /**
> 148 * If the resource was allocated using memblock early
>
> this should be formatted as normal multi-line comment inside the
> function, not in a kernel-doc fashion
I won't disagree with that. But we really can't add that many more
warnings to a docs build. Even though getting rid of all the warnings
seems like a hopeless task, it is still a goal; adding another pile will
cause any other new warnings to be completely buried.
How hard would it to talk you into submitting patches to all of the
relevant maintainers fixing the erroneous comments? :)
Thanks,
jon
prev parent reply other threads:[~2024-09-06 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 20:25 [PATCH] kernel-doc: Allow whitespace before comment start Michal Wajdeczko
2024-09-05 19:56 ` Jonathan Corbet
2024-09-05 22:43 ` Michal Wajdeczko
2024-09-06 13:49 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cylggaee.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=michal.wajdeczko@intel.com \
--cc=rmoar@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).