From: Jonathan Corbet <corbet@lwn.net>
To: Chao Liu <chaoliu719@gmail.com>,
Matthew Wilcox <willy@infradead.org>, Chao Yu <chao@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Yue Hu <huyue2@coolpad.com>, Wayne Zhang <zhangwen@coolpad.com>,
Chao Liu <liuchao@coolpad.com>
Subject: Re: [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
Date: Mon, 13 Jun 2022 11:23:07 -0600 [thread overview]
Message-ID: <87czfc1nr8.fsf@meer.lwn.net> (raw)
In-Reply-To: <Yqbu+BArbUNGvft9@liuchao-VM>
Chao Liu <chaoliu719@gmail.com> writes:
> On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
>> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
>> > v2:
>> > - s/file size/filesize/
>>
>> Why would you change it to be wrong?
>>
>
> This is a suggestion from Chao Yu. Maybe he has some other considerations.
Sorry, I should have replied to that. I disagree with that suggestion.
"Filesize" is not an English word, and there doesn't seem to be any
reason to use it in our docs.
<checks>
We have to occurrences now - one already in the f2fs docs. I think we
shouldn't add more. So my plan is to apply the first version of this
patch. Chao Liu: is there a reason why you didn't add the Reviewed-by
from Chao Yu in the second version? Chao Yu: is that tag still
applicable even without the "filesize" change?
Thanks,
jon
next prev parent reply other threads:[~2022-06-13 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 2:08 [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl Chao Liu
2022-06-13 3:37 ` Matthew Wilcox
2022-06-13 8:02 ` Chao Liu
2022-06-13 17:23 ` Jonathan Corbet [this message]
2022-06-14 1:48 ` Chao Yu
2022-06-14 2:49 ` Chao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czfc1nr8.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=chao@kernel.org \
--cc=chaoliu719@gmail.com \
--cc=huyue2@coolpad.com \
--cc=jaegeuk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=liuchao@coolpad.com \
--cc=willy@infradead.org \
--cc=zhangwen@coolpad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox