From: Jani Nikula <jani.nikula@linux.intel.com>
To: jim.cromie@gmail.com,
Linux Documentation List <linux-doc@vger.kernel.org>
Cc: Jason Baron <jbaron@akamai.com>
Subject: Re: is there a preferred form of root-prompt example ?
Date: Wed, 18 Dec 2019 08:57:55 +0200 [thread overview]
Message-ID: <87d0cm15os.fsf@intel.com> (raw)
In-Reply-To: <CAJfuBxxJptTBpEY-HYmVCy325=UZTm4BLrO0kJ2B27eKy+dx-A@mail.gmail.com>
On Tue, 17 Dec 2019, jim.cromie@gmail.com wrote:
> so Im looking at Documentation/admin-guide/dynamic-debug-howto.rst
>
> its a typical root-shell command environment.
>
> there are a lot of different example prompts scattered about,
> which is objectively inconvenient for copy-pasting.
>
> I briefly played with aliasing away the prompts, and it seems like it
> might work,
> but it seems way too magical to put into examples just to make the
> various example prompts play nice with copy-paste.
>
> At minimum, it seems good to reduce this to one or few variations,
> dir-agnostic preferred, and ideally evaluates to nil (without an ugly
> alias), leaving 1st token as the command itself.
>
> Also '//' is not a legit comment char in root-shell-environ, # is better.
> I have this and several other doc patches, this is the right place to
> send them ?
>
> comments ?
Cc: Jason, dynamic debug maintainer per MAINTAINERS
FWIW, I'd unify on single # as root prompt or just throw away the prompt
altogether, and assume /sys/kernel/debug as the debugfs path. You can
mention somewhere the privileges the examples assume, as well as tell
people to replace /sys/kernel/debug with the actual debugfs path. I'd
also unwrap the lines instead of splitting to several lines.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2019-12-18 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 20:38 is there a preferred form of root-prompt example ? jim.cromie
2019-12-18 6:57 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0cm15os.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=linux-doc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).