linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* is there a preferred form of root-prompt example ?
@ 2019-12-17 20:38 jim.cromie
  2019-12-18  6:57 ` Jani Nikula
  0 siblings, 1 reply; 2+ messages in thread
From: jim.cromie @ 2019-12-17 20:38 UTC (permalink / raw)
  To: Linux Documentation List

so Im looking at Documentation/admin-guide/dynamic-debug-howto.rst

its a typical root-shell command environment.

there are a lot of different example prompts scattered about,
which is objectively inconvenient for copy-pasting.

I briefly played with aliasing away the prompts, and it seems like it
might work,
but it seems way too magical to put into examples just to make the
various example prompts play nice with copy-paste.

At minimum, it seems good to reduce this to one or few variations,
dir-agnostic preferred, and ideally evaluates to nil (without an ugly
alias), leaving 1st token as the command itself.

Also '//' is not a legit comment char in root-shell-environ, # is better.
I have this and several other doc patches, this is the right place to
send them ?

comments ?

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: is there a preferred form of root-prompt example ?
  2019-12-17 20:38 is there a preferred form of root-prompt example ? jim.cromie
@ 2019-12-18  6:57 ` Jani Nikula
  0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2019-12-18  6:57 UTC (permalink / raw)
  To: jim.cromie, Linux Documentation List; +Cc: Jason Baron

On Tue, 17 Dec 2019, jim.cromie@gmail.com wrote:
> so Im looking at Documentation/admin-guide/dynamic-debug-howto.rst
>
> its a typical root-shell command environment.
>
> there are a lot of different example prompts scattered about,
> which is objectively inconvenient for copy-pasting.
>
> I briefly played with aliasing away the prompts, and it seems like it
> might work,
> but it seems way too magical to put into examples just to make the
> various example prompts play nice with copy-paste.
>
> At minimum, it seems good to reduce this to one or few variations,
> dir-agnostic preferred, and ideally evaluates to nil (without an ugly
> alias), leaving 1st token as the command itself.
>
> Also '//' is not a legit comment char in root-shell-environ, # is better.
> I have this and several other doc patches, this is the right place to
> send them ?
>
> comments ?

Cc: Jason, dynamic debug maintainer per MAINTAINERS

FWIW, I'd unify on single # as root prompt or just throw away the prompt
altogether, and assume /sys/kernel/debug as the debugfs path. You can
mention somewhere the privileges the examples assume, as well as tell
people to replace /sys/kernel/debug with the actual debugfs path. I'd
also unwrap the lines instead of splitting to several lines.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-18  6:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-17 20:38 is there a preferred form of root-prompt example ? jim.cromie
2019-12-18  6:57 ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).