From: Jonathan Corbet <corbet@lwn.net>
To: Peter Foley <pefoley2@pefoley.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Peter Foley <pefoley2@pefoley.com>
Subject: Re: [PATCH] Documentation: Avoid duplicate Kconfig inclusion
Date: Sat, 14 Jan 2023 09:25:22 -0700 [thread overview]
Message-ID: <87edrxgk25.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230114-doc-v1-1-efec2689e423@pefoley.com>
Peter Foley <pefoley2@pefoley.com> writes:
> Documentation/Kconfig is already included from lib/Kconfig.debug, avoid
> including it again and polluting the top-level menu.
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
> ---
> Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Kconfig b/Kconfig
> index 745bc773f5670..97ed6389c9211 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -28,5 +28,3 @@ source "crypto/Kconfig"
> source "lib/Kconfig"
>
> source "lib/Kconfig.debug"
> -
> -source "Documentation/Kconfig"
>
The duplicate inclusion does seem worth fixing, but I wonder if you're
deleting the right one? Having the documentation Kconfig under lib
seems a bit strange, somehow; Documentation/ is a top-level directory,
after all.
Thanks,
jon
next prev parent reply other threads:[~2023-01-14 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 6:08 [PATCH] Documentation: Avoid duplicate Kconfig inclusion Peter Foley
2023-01-14 16:25 ` Jonathan Corbet [this message]
2023-01-16 0:42 ` Peter Foley
2023-01-16 0:55 ` Randy Dunlap
2023-01-16 22:59 ` Peter Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edrxgk25.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=pefoley2@pefoley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox