From: Jonathan Corbet <corbet@lwn.net>
To: "wangjianjian (C)" <wangjianjian3@huawei.com>,
tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] ext4, doc: Fix incorrect h_reserved size
Date: Sat, 16 Apr 2022 02:58:08 -0600 [thread overview]
Message-ID: <87ee1x2yn3.fsf@meer.lwn.net> (raw)
In-Reply-To: <34889f32-7dd9-125e-2f7a-734faa395d20@huawei.com>
"wangjianjian (C)" <wangjianjian3@huawei.com> writes:
> According to document and code, ext4_xattr_header's size is 32 bytes, so
> h_reserved size should be 3.
>
> Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
> ---
> Documentation/filesystems/ext4/attributes.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/ext4/attributes.rst
> b/Documentation/filesystems/ext4/attributes.rst
> index 54386a010a8d..871d2da7a0a9 100644
> --- a/Documentation/filesystems/ext4/attributes.rst
> +++ b/Documentation/filesystems/ext4/attributes.rst
> @@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
> - Checksum of the extended attribute block.
> * - 0x14
> - \_\_u32
> - - h\_reserved[2]
> + - h\_reserved[3]
> - Zero.
>
So this patch looks whitespace-damaged, please be sure that you can send
applyable patches to the list.
Beyond that, though, while you're in the neighborhood, please fix the
unnecessary underscore escaping (i.e. s/\_/_/).
Thanks,
jon
next prev parent reply other threads:[~2022-04-16 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 6:37 [PATCH] ext4, doc: Fix incorrect h_reserved size wangjianjian (C)
2022-04-01 12:07 ` wangjianjian (C)
2022-04-03 14:53 ` Theodore Ts'o
2022-04-16 8:58 ` Jonathan Corbet [this message]
2022-04-19 8:31 ` wangjianjian (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee1x2yn3.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=adilger.kernel@dilger.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wangjianjian3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).