[PATCH] ext4, doc: Fix incorrect h_reserved size

[PATCH] ext4, doc: Fix incorrect h_reserved size

[wangjianjian (C)]

According to document and code, ext4_xattr_header's size is 32 bytes, so
h_reserved size should be 3.

Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
---
  Documentation/filesystems/ext4/attributes.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/filesystems/ext4/attributes.rst 
b/Documentation/filesystems/ext4/attributes.rst
index 54386a010a8d..871d2da7a0a9 100644
--- a/Documentation/filesystems/ext4/attributes.rst
+++ b/Documentation/filesystems/ext4/attributes.rst
@@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
       - Checksum of the extended attribute block.
     * - 0x14
       - \_\_u32
-     - h\_reserved[2]
+     - h\_reserved[3]
       - Zero.

  The checksum is calculated against the FS UUID, the 64-bit block number
--
2.32.0

[PATCH] ext4, doc: Fix incorrect h_reserved size

[wangjianjian (C)]

According to document and code, ext4_xattr_header's size is 32 bytes, so
h_reserved size should be 3.

Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
---
  Documentation/filesystems/ext4/attributes.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/filesystems/ext4/attributes.rst 
b/Documentation/filesystems/ext4/attributes.rst
index 54386a010a8d..871d2da7a0a9 100644
--- a/Documentation/filesystems/ext4/attributes.rst
+++ b/Documentation/filesystems/ext4/attributes.rst
@@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
       - Checksum of the extended attribute block.
     * - 0x14
       - \_\_u32
-     - h\_reserved[2]
+     - h\_reserved[3]
       - Zero.

  The checksum is calculated against the FS UUID, the 64-bit block number
-- 
2.32.0

Re: [PATCH] ext4, doc: Fix incorrect h_reserved size

[Theodore Ts'o]

On Fri, 1 Apr 2022 20:07:35 +0800, wangjianjian (C) wrote:
> According to document and code, ext4_xattr_header's size is 32 bytes, so
> h_reserved size should be 3.
> 
> 

Applied, thanks!

[1/1] ext4, doc: Fix incorrect h_reserved size
      commit: e830f1a05b203e8b9b81606caf6b5d68458ba732

Note that this patch was whitespace damaged, so I had to manually
apply the patch.  It appears that all TAB characters had been replaced
with the bytes 0xC2 0x020, which is the UTF-8 encoding for U+0082, aka
'BREAK PERMITTED HERE'.  That seems.... wierd; I don't know how that
would ever be considered a valid character set transformation.

In any case, you might want to look at your Mail User Agent and see if
there are some settings you can adjust.

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>

Re: [PATCH] ext4, doc: Fix incorrect h_reserved size

[Jonathan Corbet]

"wangjianjian (C)" <wangjianjian3@huawei.com> writes:

> According to document and code, ext4_xattr_header's size is 32 bytes, so
> h_reserved size should be 3.
>
> Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
> ---
>   Documentation/filesystems/ext4/attributes.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/ext4/attributes.rst 
> b/Documentation/filesystems/ext4/attributes.rst
> index 54386a010a8d..871d2da7a0a9 100644
> --- a/Documentation/filesystems/ext4/attributes.rst
> +++ b/Documentation/filesystems/ext4/attributes.rst
> @@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
>        - Checksum of the extended attribute block.
>      * - 0x14
>        - \_\_u32
> -     - h\_reserved[2]
> +     - h\_reserved[3]
>        - Zero.
>

So this patch looks whitespace-damaged, please be sure that you can send
applyable patches to the list.

Beyond that, though, while you're in the neighborhood, please fix the
unnecessary underscore escaping (i.e. s/\_/_/).

Thanks,

jon

Re: [PATCH] ext4, doc: Fix incorrect h_reserved size

[wangjianjian (C)]

 >>So this patch looks whitespace-damaged, please be sure that you can send
 >> applyable patches to the list.
Thanks for the notice.

 >> Beyond that, though, while you're in the neighborhood, please fix the
 >> unnecessary underscore escaping (i.e. s/\_/_/).
Sure. Let me fix it.

Thanks,