Re: [PATCH] docs/sp_SP: Add memory-barriers.txt Spanish translation

Re: [PATCH] docs/sp_SP: Add memory-barriers.txt Spanish translation

[Jonathan Corbet]

Carlos Bilbao <carlos.bilbao@amd.com> writes:

> Translate the following documents into Spanish:
>
> - memory-barriers.txt
>
> Also include it on index of Spanish translations, following the same
> approach used by the Korean translation, as a note at the end of the index.
>
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
> ---
>  Documentation/translations/sp_SP/index.rst    |    4 +
>  .../translations/sp_SP/memory-barriers.txt    | 3134 +++++++++++++++++
>  2 files changed, 3138 insertions(+)
>  create mode 100644 Documentation/translations/sp_SP/memory-barriers.txt
>
> diff --git a/Documentation/translations/sp_SP/index.rst b/Documentation/translations/sp_SP/index.rst
> index e20dd6e875e7..61dace3df9a6 100644
> --- a/Documentation/translations/sp_SP/index.rst
> +++ b/Documentation/translations/sp_SP/index.rst
> @@ -79,3 +79,7 @@ Traducciones al español
>  
>     howto
>     submitting-patches
> +
> +.. include:: ./memory-barriers.txt
> +    :literal:

That's an awfully big "note" to add at the end of the index file; I
don't really think that's the best experience for our readers.  Can this
be done using the wrapper documents like for English in current
docs-next?

Thanks,

jon

Re: [PATCH] docs/sp_SP: Add memory-barriers.txt Spanish translation

[Carlos Bilbao]

On 11/21/22 15:10, Jonathan Corbet wrote:

> Carlos Bilbao <carlos.bilbao@amd.com> writes:
>
>> Translate the following documents into Spanish:
>>
>> - memory-barriers.txt
>>
>> Also include it on index of Spanish translations, following the same
>> approach used by the Korean translation, as a note at the end of the index.
>>
>> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
>> ---
>>   Documentation/translations/sp_SP/index.rst    |    4 +
>>   .../translations/sp_SP/memory-barriers.txt    | 3134 +++++++++++++++++
>>   2 files changed, 3138 insertions(+)
>>   create mode 100644 Documentation/translations/sp_SP/memory-barriers.txt
>>
>> diff --git a/Documentation/translations/sp_SP/index.rst b/Documentation/translations/sp_SP/index.rst
>> index e20dd6e875e7..61dace3df9a6 100644
>> --- a/Documentation/translations/sp_SP/index.rst
>> +++ b/Documentation/translations/sp_SP/index.rst
>> @@ -79,3 +79,7 @@ Traducciones al español
>>   
>>      howto
>>      submitting-patches
>> +
>> +.. include:: ./memory-barriers.txt
>> +    :literal:
> That's an awfully big "note" to add at the end of the index file; I
> don't really think that's the best experience for our readers.  Can this
> be done using the wrapper documents like for English in current
> docs-next?


Yes that makes more sense. Sending v2 :)


>
> Thanks,
>
> jon


Thanks,

Carlos

Re: [PATCH v2] docs/sp_SP: Add memory-barriers.txt Spanish translation

[Jonathan Corbet]

Carlos Bilbao <carlos.bilbao@amd.com> writes:

> Translate the following documents into Spanish:
>
> - memory-barriers.txt
>
> using the wrapper documents system.
>
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
> ---
>  Documentation/translations/sp_SP/index.rst    |    1 +
>  .../translations/sp_SP/memory-barriers.txt    | 3134 +++++++++++++++++
>  .../sp_SP/wrappers/memory-barriers.rst        |   19 +
>  3 files changed, 3154 insertions(+)
>  create mode 100644 Documentation/translations/sp_SP/memory-barriers.txt
>  create mode 100644 Documentation/translations/sp_SP/wrappers/memory-barriers.rst

I've applied this, thanks.

For future reference, it would make life just a little easier if you'd
put patches inline rather than as attachments.

Thanks,

jon

Re: [PATCH v2] docs/sp_SP: Add memory-barriers.txt Spanish translation

[Carlos Bilbao]

On 12/3/22 5:16 AM, Jonathan Corbet wrote:
> Carlos Bilbao <carlos.bilbao@amd.com> writes:
> 
>> Translate the following documents into Spanish:
>>
>> - memory-barriers.txt
>>
>> using the wrapper documents system.
>>
>> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
>> ---
>>  Documentation/translations/sp_SP/index.rst    |    1 +
>>  .../translations/sp_SP/memory-barriers.txt    | 3134 +++++++++++++++++
>>  .../sp_SP/wrappers/memory-barriers.rst        |   19 +
>>  3 files changed, 3154 insertions(+)
>>  create mode 100644 Documentation/translations/sp_SP/memory-barriers.txt
>>  create mode 100644 Documentation/translations/sp_SP/wrappers/memory-barriers.rst
> 
> I've applied this, thanks.
> 
> For future reference, it would make life just a little easier if you'd
> put patches inline rather than as attachments.

That's weird, I just used git send-email. Maybe it showed up as an
attachment due to its large size.

> 
> Thanks,
> 
> jon

Thanks,
Carlos