From: Jonathan Corbet <corbet@lwn.net>
To: Roland Hieber <rhi@pengutronix.de>, Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/3] docs: tracing: use refs for cross-referencing
Date: Wed, 16 Mar 2022 15:48:56 -0600 [thread overview]
Message-ID: <87fsnhsh4n.fsf@meer.lwn.net> (raw)
In-Reply-To: <20220314114644.6unqdbpxcsqin3qu@pengutronix.de>
Roland Hieber <rhi@pengutronix.de> writes:
> On Sun, Mar 13, 2022 at 07:55:19PM -0400, Steven Rostedt wrote:
>> On Sun, 13 Mar 2022 11:55:55 +0100
>> Roland Hieber <rhi@pengutronix.de> wrote:
>>
>> > Help cross-linking the documents by using the :ref: role.
>>
>> Note, I and many other people read the .rst files directly, and do not
>> rely on any processing. Is there a better way to do a cross reference
>> like this, because I find this a bit ugly to read.
>
> The main point of this series was to get rid of the manually numbered
> sections (which the next patch does). Relying on manual section numbers
> for cross-referencing is error-prone, which my first iteration of the
> patch already showed… Unfortunately, the sphinx reST syntax is not very
> flexible here.
I agree on the removal of the numbered sections. Those always end up
being wrong after a while.
> I could imagine leaving the file names in when a reference points to a
> different document, like in this hunk:
>
>> > -set_ftrace_filter 'ftrace filter commands' (see the 'Filter commands'
>> > -section of Documentation/trace/ftrace.rst), but there are major
>> > +set_ftrace_filter 'ftrace filter commands' (see the section
>> > +:ref:`ftrace_filter_commands`), but there are major
In general, all of those references and labels clutter the source
considerably and aren't hugely useful to readers of the plain-text
documents. There are times when they are the best thing to do, but I
think that moderation is indicated. Just giving the file name will
generate a cross-reference to that file; I would hope that would be
enough most of the time.
Thanks,
jon
next prev parent reply other threads:[~2022-03-16 21:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 10:55 [PATCH 1/3] docs: tracing: use refs for cross-referencing Roland Hieber
2022-03-13 10:55 ` [PATCH 2/3] docs: trace: bring headings in order Roland Hieber
2022-03-14 0:01 ` Steven Rostedt
2022-03-14 11:28 ` Roland Hieber
2022-03-13 10:55 ` [PATCH 3/3] docs: trace: events: apply literal markup Roland Hieber
2022-03-14 0:04 ` Steven Rostedt
2022-03-13 23:55 ` [PATCH 1/3] docs: tracing: use refs for cross-referencing Steven Rostedt
2022-03-14 11:46 ` Roland Hieber
2022-03-16 21:48 ` Jonathan Corbet [this message]
2022-03-16 21:52 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsnhsh4n.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=bristot@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rhi@pengutronix.de \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).