Re: [PATCH 2/2] docs: media: Debugging guide for the media subsystem

[Jonathan Corbet <corbet@lwn.net>]

Sebastian Fricke <sebastian.fricke@collabora.com> writes:

> Provide a guide for developers on how to debug code with a focus on the
> media subsystem. This document aims to provide a rough overview over the
> possibilities and a rational to help choosing the right tool for the
> given circumstances.
>
> Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
> ---
>  Documentation/process/debugging/index.rst          |   1 +
>  .../debugging/media_specific_debugging_guide.rst   | 178 +++++++++++++++++++++
>  2 files changed, 179 insertions(+)

Mostly overall comments here

- much of what's here seems redundant with your other new documents; you
  seem to be going over the same list of tools?  Why not just talk about
  the ones that are unique to the media subsystem?

- Please use the function() convention throughout.

- Back in the ancient past when I was writing V4L2 drivers, one of my
  biggest problems was figuring out why applications weren't getting
  what they expected.  The vivi driver was most useful for finding
  subtle differences...  One would use vivid now, but I suspect the
  utility remains.

Thanks,

jon