From: Jonathan Corbet <corbet@lwn.net>
To: Kees Cook <keescook@chromium.org>
Cc: Kees Cook <keescook@chromium.org>,
Randy Dunlap <rdunlap@infradead.org>,
Joe Perches <joe@perches.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v4] docs: Explain the desired position of function attributes
Date: Mon, 04 Oct 2021 17:09:18 -0600 [thread overview]
Message-ID: <87h7dw75gh.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210930235754.2635912-1-keescook@chromium.org>
Kees Cook <keescook@chromium.org> writes:
> While discussing how to format the addition of various function
> attributes, some "unwritten rules" of ordering surfaced[1]. Capture as
> close as possible to Linus's preferences for future reference.
>
> (Though I note the dissent voiced by Joe Perches, Alexey Dobriyan, and
> others that would prefer all attributes live on a separate leading line.)
>
> [1] https://lore.kernel.org/mm-commits/CAHk-=wiOCLRny5aifWNhr621kYrJwhfURsa0vFPeUEm8mF0ufg@mail.gmail.com/
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v4:
> - fix another stray "void"! This is why code needs a compiler... (thx randy)
> ---
> Documentation/process/coding-style.rst | 30 ++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
Did I ever mention that I *hate* coding-style patches? :)
In this case I think we're as close as to consensus as things get. In
the absence of a strong reason to the contrary, I'll apply this before
too long.
Thanks,
jon
next prev parent reply other threads:[~2021-10-04 23:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 23:57 [PATCH v4] docs: Explain the desired position of function attributes Kees Cook
2021-10-01 19:05 ` Nick Desaulniers
2021-10-01 20:23 ` Joe Perches
2021-10-02 0:00 ` Kees Cook
2021-10-02 6:31 ` Greg KH
2021-10-02 10:42 ` Miguel Ojeda
2021-10-02 15:22 ` Joe Perches
2021-10-02 16:29 ` Miguel Ojeda
2021-10-02 15:21 ` Joe Perches
2021-10-02 16:27 ` Miguel Ojeda
2021-10-02 21:42 ` Kees Cook
2021-10-02 10:46 ` Miguel Ojeda
2021-10-04 23:09 ` Jonathan Corbet [this message]
2021-10-05 8:28 ` Miguel Ojeda
2021-10-05 14:58 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7dw75gh.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ndesaulniers@google.com \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).