From: Valentin Schneider <valentin.schneider@arm.com>
To: Barry Song <song.bao.hua@hisilicon.com>,
peterz@infradead.org, corbet@lwn.net
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, Barry Song <song.bao.hua@hisilicon.com>
Subject: Re: [PATCH] Documentation: scheduler: sched_debug_verbose cmdline should be sched_verbose
Date: Tue, 04 May 2021 12:09:24 +0100 [thread overview]
Message-ID: <87h7jiycuz.mognet@arm.com> (raw)
In-Reply-To: <20210504105344.31344-1-song.bao.hua@hisilicon.com>
On 04/05/21 22:53, Barry Song wrote:
> The cmdline should include sched_verbose but not sched_debug_verbose
> as sched_debug_verbose is only the variant name in code.
>
> Fixes: 9406415f46 ("sched/debug: Rename the sched_debug parameter to sched_verbose")
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
> ---
> Documentation/scheduler/sched-domains.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/scheduler/sched-domains.rst b/Documentation/scheduler/sched-domains.rst
> index 14ea2f2..84dcdcd 100644
> --- a/Documentation/scheduler/sched-domains.rst
> +++ b/Documentation/scheduler/sched-domains.rst
> @@ -74,7 +74,7 @@ for a given topology level by creating a sched_domain_topology_level array and
> calling set_sched_topology() with this array as the parameter.
>
> The sched-domains debugging infrastructure can be enabled by enabling
> -CONFIG_SCHED_DEBUG and adding 'sched_debug_verbose' to your cmdline. If you
> +CONFIG_SCHED_DEBUG and adding 'sched_verbose' to your cmdline. If you
> forgot to tweak your cmdline, you can also flip the
> /sys/kernel/debug/sched/verbose knob. This enables an error checking parse of
> the sched domains which should catch most possible errors (described above). It
> --
> 1.8.3.1
prev parent reply other threads:[~2021-05-04 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 10:53 [PATCH] Documentation: scheduler: sched_debug_verbose cmdline should be sched_verbose Barry Song
2021-05-04 11:09 ` Valentin Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7jiycuz.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=peterz@infradead.org \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).