From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF0CC433E0 for ; Mon, 22 Feb 2021 21:00:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8C1F64E25 for ; Mon, 22 Feb 2021 21:00:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbhBVVAk (ORCPT ); Mon, 22 Feb 2021 16:00:40 -0500 Received: from ms.lwn.net ([45.79.88.28]:34112 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229934AbhBVVAk (ORCPT ); Mon, 22 Feb 2021 16:00:40 -0500 Received: from localhost (unknown [IPv6:2601:281:8300:104d::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id E071330D; Mon, 22 Feb 2021 20:59:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net E071330D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1614027599; bh=uCB8Hgwaf+lNKimvvf9tQZlF3BSKiETK4qc1TCmNd18=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kaLWH++b7x3gCrgO2e97h3hLmlCS2bCHXpPcqHTC+hnEzOydtFi8uY/7v+2LWBasy pdgY7Fb64JtnogF65eqEMN3Mx+9pET01gn9DJcnVq35LXQbyUQjfQxXn1Ln8uBE7RY MAp1cqnosIyyk2i9je2TBYgWDQqONHmIcw/X6Sk4cGsFvyYVQ30FfIusZpAh8OrcZs PeF67BflaU6Ps8dy7N5z5gKebLYMe3sJdFfJZjYXM1quJJFlvFMJY7Nxddu58eO7aA 48QwTHKExhb617tMl3FuQ95PbBD9Ez2Sl3KF1X1gLjpw19id92bgMjgF6XQdh42cQ7 eJniFyeQRAmZA== From: Jonathan Corbet To: Masahiro Yamada , linux-doc@vger.kernel.org Cc: Masahiro Yamada , Alex Shi , Daniel Vetter , David Airlie , Federico Vaga , Harry Wei , Jyri Sarha , Tomi Valkeinen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags from command line In-Reply-To: <20210221152524.197693-1-masahiroy@kernel.org> References: <20210221152524.197693-1-masahiroy@kernel.org> Date: Mon, 22 Feb 2021 13:59:58 -0700 Message-ID: <87h7m3lsxd.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Masahiro Yamada writes: > You should use KCFLAGS to pass additional compiler flags from the > command line. Using EXTRA_CFLAGS is wrong. > > EXTRA_CFLAGS is supposed to specify flags applied only to the current > Makefile (and now deprecated in favor of ccflags-y). > > It is still used in arch/mips/kvm/Makefile (and possibly in external > modules too). Passing EXTRA_CFLAGS from the command line overwrites > it and breaks the build. > > I also fixed drivers/gpu/drm/tilcdc/Makefile because commit 816175dd1fd7 > ("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in > EXTRA_CFLAGS") was based on the same misunderstanding. > > Signed-off-by: Masahiro Yamada > --- > > Documentation/process/4.Coding.rst | 2 +- > Documentation/process/submit-checklist.rst | 2 +- > Documentation/translations/it_IT/process/4.Coding.rst | 2 +- > Documentation/translations/it_IT/process/submit-checklist.rst | 2 +- > Documentation/translations/zh_CN/process/4.Coding.rst | 2 +- > drivers/gpu/drm/tilcdc/Makefile | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) I've applied this, fixing the conflict with submit-checklist.rst in the process. Thanks, jon