From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07E1DC4727D for ; Tue, 29 Sep 2020 14:37:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 911682074F for ; Tue, 29 Sep 2020 14:37:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="V1+jfdup"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="sPt4IoTc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730757AbgI2OhN (ORCPT ); Tue, 29 Sep 2020 10:37:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728630AbgI2OhJ (ORCPT ); Tue, 29 Sep 2020 10:37:09 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF6EFC061755 for ; Tue, 29 Sep 2020 07:37:08 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1601390224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7VmCiL2ZmrGBEC6BMl9JAzfcplFXUuQxSEoukFP38Qc=; b=V1+jfdupgUDguwQLoSfM1UDKyK97umPBk3RCJPtrXvo3HjkrAv7oZ8d769kr1UDVOiqeTZ dYLZ91gc/sIaO50hcs95TdgAz48RhfBSdsMS4DBcFHFsnovSq6VpdWIndCw/TDoShwfw6K +9gek94Fbm54gtYRDPDw8mmMw1zu7wsXy4XgCJqs+Ou4lV81QykEgsNo9DjLsy3AKB/AQT G576m9HeX1S7jQnyrTObW1HKy1c9vZ/qj50V8IIaFz92XDLpVe1/eK2AHh590q7RBBj8DC CNoJkwrvYs+wq1wIIZrzEBqJCA9sxTEj2C2ebwz12LDtKQOxv8zXpvTIG+C0Uw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1601390224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7VmCiL2ZmrGBEC6BMl9JAzfcplFXUuQxSEoukFP38Qc=; b=sPt4IoTcBHRSkKQG9REMY6x9b+3JCLHw6ozsiGzdslM4l4/myrfh7jYnJBRfn53aNiiK7S jsmrp6TrTiHQFoDA== To: Shannon Nelson , LKML Cc: Peter Zijlstra , Linus Torvalds , Paul McKenney , Matthew Wilcox , Sebastian Andrzej Siewior , Pensando Drivers , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Christian Benvenuti , Govindarajulu Varadarajan <_govind@gmx.com>, Jonathan Corbet , Mauro Carvalho Chehab , linux-doc@vger.kernel.org, Luc Van Oostenryck , Jay Cliburn , Chris Snook , Vishal Kulkarni , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, Andrew Lunn , Heiner Kallweit , Russell King , Thomas Bogendoerfer , Solarflare linux maintainers , Edward Cree , Martin Habets , Jon Mason , Daniel Drake , Ulrich Kunitz , Kalle Valo , linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, Greg Kroah-Hartman , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Stanislav Yakovlev , Stanislaw Gruszka , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Jouni Malinen , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , libertas-dev@lists.infradead.org, Pascal Terjan , Ping-Ke Shih Subject: Re: [patch 11/35] net: ionic: Replace in_interrupt() usage. In-Reply-To: <1d0950f8-cab4-9ef2-6cf7-73b71b750a8d@pensando.io> References: <20200927194846.045411263@linutronix.de> <20200927194920.918550822@linutronix.de> <5e4c3201-9d90-65b1-5c13-e2381445be1d@pensando.io> <1d0950f8-cab4-9ef2-6cf7-73b71b750a8d@pensando.io> Date: Tue, 29 Sep 2020 16:37:04 +0200 Message-ID: <87h7rgk5tb.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Sep 28 2020 at 12:51, Shannon Nelson wrote: > On 9/28/20 10:24 AM, Shannon Nelson wrote: >>> ionic_lif_addr() can be called from: >>> >>> =C2=A0 1) ->ndo_set_rx_mode() which is under netif_addr_lock_bh()) so i= t=20 >>> must not >>> =C2=A0=C2=A0=C2=A0=C2=A0 sleep. >>> >>> =C2=A0 2) Init and setup functions which are in fully preemptible task= =20 >>> context. >>> >>> _ionic_lif_rx_mode() has only one call path with BH disabled. > > Now that I've had my coffee, let's look at this again - there are=20 > multiple paths that get us to _ionic_lif_rx_mode(): > > .ndo_set_rx_mode > =C2=A0 ionic_set_rx_mode, > =C2=A0=C2=A0=C2=A0 _ionic_lif_rx_mode > > { ionic_open, ionic_lif_handle_fw_up, ionic_start_queues_reconfig } > =C2=A0=C2=A0=C2=A0 ionic_txrx_init > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ionic_set_rx_mode > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 _ionic_lif_rx_mode Hrm. Let me stare at it again...