From: Jonathan Corbet <corbet@lwn.net>
To: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 1/1] docs: proc.rst: comm: mention the included NUL
Date: Thu, 08 Feb 2024 15:47:14 -0700 [thread overview]
Message-ID: <87il2yfua5.fsf@meer.lwn.net> (raw)
In-Reply-To: <20240206022237.794761-2-mail@christoph.anton.mitterer.name>
Christoph Anton Mitterer <mail@christoph.anton.mitterer.name> writes:
> Indicate that the actual value will be one character less.
>
> Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
> ---
> Documentation/filesystems/proc.rst | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 104c6d047d9b..c0e92a056079 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -1899,8 +1899,9 @@ For more information on mount propagation see:
> These files provide a method to access a task's comm value. It also allows for
> a task to set its own or one of its thread siblings comm value. The comm value
> is limited in size compared to the cmdline value, so writing anything longer
> -then the kernel's TASK_COMM_LEN (currently 16 chars) will result in a truncated
> -comm value.
> +then the kernel's TASK_COMM_LEN (currently 16 chars, including the null
> +terminator, which is printed as the line feed character in the file) will result
> +in a truncated comm value.
I don't understand the line-feed comment at all; printed by whom?
I think I'll just apply the first version, which explained the situation
well enough.
Thanks,
jon
next prev parent reply other threads:[~2024-02-08 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 15:41 [PATCH] docs: proc.rst: comm: mention the included NUL Christoph Anton Mitterer
2024-02-06 2:22 ` [PATCH v2 0/1] " Christoph Anton Mitterer
2024-02-06 2:22 ` [PATCH v2 1/1] " Christoph Anton Mitterer
2024-02-08 22:47 ` Jonathan Corbet [this message]
2024-02-08 22:58 ` Christoph Anton Mitterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il2yfua5.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=mail@christoph.anton.mitterer.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox