From: Jonathan Corbet <corbet@lwn.net>
To: Olaf Hering <olaf@aepfle.de>,
"Paul E. McKenney" <paulmck@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
Kim Phillips <kim.phillips@amd.com>,
Wyes Karny <wyes.karny@amd.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Prarit Bhargava <prarit@redhat.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
rcu@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v1] Fix documentation of panic_on_warn
Date: Mon, 03 Jul 2023 08:36:27 -0600 [thread overview]
Message-ID: <87ilb1jc44.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230630145307.25865-1-olaf@aepfle.de>
Olaf Hering <olaf@aepfle.de> writes:
> The kernel cmdline option panic_on_warn expects an integer, it is not a
> plain option as documented. A number of uses in the tree figured this
> already, and use panic_on_warn=1 for their purpose.
>
> Adjust a comment which otherwise may mislead people in the future.
>
> Fixes: 9e3961a097 ("kernel: add panic_on_warn")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 2 +-
> tools/testing/selftests/rcutorture/bin/kvm.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 9e5bab29685f..15196f84df49 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4049,7 +4049,7 @@
> extra details on the taint flags that users can pick
> to compose the bitmask to assign to panic_on_taint.
>
> - panic_on_warn panic() instead of WARN(). Useful to cause kdump
> + panic_on_warn=1 panic() instead of WARN(). Useful to cause kdump
> on a WARN().
Applied, thanks.
jon
prev parent reply other threads:[~2023-07-03 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 14:53 [PATCH v1] Fix documentation of panic_on_warn Olaf Hering
2023-06-30 21:58 ` Randy Dunlap
2023-07-03 14:36 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilb1jc44.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=kim.phillips@amd.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=olaf@aepfle.de \
--cc=paulmck@kernel.org \
--cc=prarit@redhat.com \
--cc=rcu@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=wyes.karny@amd.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).