From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3F8FC001B1 for ; Mon, 3 Jul 2023 14:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbjGCOgc (ORCPT ); Mon, 3 Jul 2023 10:36:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbjGCOga (ORCPT ); Mon, 3 Jul 2023 10:36:30 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4993794; Mon, 3 Jul 2023 07:36:28 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id AEC2C31A; Mon, 3 Jul 2023 14:36:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net AEC2C31A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1688394987; bh=RhCEIGtxJGVeV91EVDUY0yOhsp0I7Oxy2bLYCQ2RLRs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=i8En8lM+1Y6yKeeV2T7+Cf25m0U1/2TX4sskHWsT08HjQSaB7IKSbJzPq4RP6qf8M pUfthZR6CBMFOazfPm4Niv0ZnLz5wrp1AR9519CEvBPg0Fk/Ytxl4rF4pEb3ITcgZ0 lCAwUQtFcckZGWEMKnrUOmVWgXwHqd1VqSK4jGUA2QKjKMtrAk3K03zGl2DcIM2FoZ FLvHnP5rIPYBUpydER5JJoVEJHulntKYNlDj0Yw68hhAZA+S5dhjeGBjaLirzXV+sW g6fGO5sND7+ECIzodWiUFmug2slV0W1fKlr7AkkrvZVzOSXkgJPUaE2RNGSmH3skCZ hshplsxiqQ77g== From: Jonathan Corbet To: Olaf Hering , "Paul E. McKenney" , Andrew Morton , Randy Dunlap , Catalin Marinas , "Steven Rostedt (Google)" , Kim Phillips , Wyes Karny , Tiezhu Yang , Prarit Bhargava , Yasuaki Ishimatsu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Shuah Khan Subject: Re: [PATCH v1] Fix documentation of panic_on_warn In-Reply-To: <20230630145307.25865-1-olaf@aepfle.de> References: <20230630145307.25865-1-olaf@aepfle.de> Date: Mon, 03 Jul 2023 08:36:27 -0600 Message-ID: <87ilb1jc44.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Olaf Hering writes: > The kernel cmdline option panic_on_warn expects an integer, it is not a > plain option as documented. A number of uses in the tree figured this > already, and use panic_on_warn=1 for their purpose. > > Adjust a comment which otherwise may mislead people in the future. > > Fixes: 9e3961a097 ("kernel: add panic_on_warn") > > Signed-off-by: Olaf Hering > --- > Documentation/admin-guide/kernel-parameters.txt | 2 +- > tools/testing/selftests/rcutorture/bin/kvm.sh | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 9e5bab29685f..15196f84df49 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -4049,7 +4049,7 @@ > extra details on the taint flags that users can pick > to compose the bitmask to assign to panic_on_taint. > > - panic_on_warn panic() instead of WARN(). Useful to cause kdump > + panic_on_warn=1 panic() instead of WARN(). Useful to cause kdump > on a WARN(). Applied, thanks. jon