From: Jonathan Corbet <corbet@lwn.net>
To: Akira Yokosawa <akiyks@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-doc@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH v3 0/2] docs: conf.py: Reduce texlive dependency
Date: Mon, 29 Aug 2022 10:52:52 -0600 [thread overview]
Message-ID: <87ilmbouu3.fsf@meer.lwn.net> (raw)
In-Reply-To: <9b8ff6d7-e97a-c03f-7d46-4b80ae3cf196@gmail.com>
Akira Yokosawa <akiyks@gmail.com> writes:
> Hi,
>
> This is v3 which addresses Jon's comments to v2 [1], but slightly
> different ways from Jon's suggestions.
>
> Changes since v2 [1]:
> - Drop Patch 3/3, which is in docs-fixes now.
> - Patch 1/2:
> o Simplify find_command() by using shutil.which(). For guessing
> available commands, it should be good enough.
> o Mention find_command() in the changelog.
> - Patch 2/2:
> o Instead of silently ignoring unknown setting of SPHINX_IMGMATH,
> print a warning msg.
>
> Acked-bys from Mauro are kept, as I assume these changes wouldn't
> affect the purpose of each patch.
>
> Changes since v1 [2]:
> - Patch 2/3: Rename LOAD_IMGMATH -> SPHINX_IMGMATH (Mauro).
> - For the series: Acked-bys from Mauro.
Set applied, thanks. I did make one change to patch 1, see my reply
there.
jon
prev parent reply other threads:[~2022-08-29 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 4:35 [PATCH v3 0/2] docs: conf.py: Reduce texlive dependency Akira Yokosawa
2022-08-27 4:37 ` [PATCH v3 1/2] docs/conf.py: Treat mathjax as fallback math renderer Akira Yokosawa
2022-08-29 16:59 ` Jonathan Corbet
2022-08-27 4:38 ` [PATCH v3 2/2] docs/conf.py: Respect env variable SPHINX_IMGMATH Akira Yokosawa
2022-08-28 0:38 ` Randy Dunlap
2022-08-28 3:47 ` Akira Yokosawa
2022-08-28 4:59 ` Randy Dunlap
2022-08-29 16:52 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilmbouu3.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akiyks@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).