From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id C3E1E7D099 for ; Thu, 21 Mar 2019 13:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728129AbfCUN23 (ORCPT ); Thu, 21 Mar 2019 09:28:29 -0400 Received: from mga12.intel.com ([192.55.52.136]:1661 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728102AbfCUN23 (ORCPT ); Thu, 21 Mar 2019 09:28:29 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 06:28:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,252,1549958400"; d="scan'208";a="157045491" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.172]) by fmsmga001.fm.intel.com with ESMTP; 21 Mar 2019 06:28:26 -0700 From: Jani Nikula To: Sean Christopherson , Jonathan Corbet Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Jorge Ramirez-Ortiz , Jonathan Cameron , Joe Perches , Greg Kroah-Hartman , Niklas Cassel Subject: Re: [PATCH] docs: Explicitly state ordering requirements for Co-developed-by In-Reply-To: <20190320151140.32432-1-sean.j.christopherson@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20190320151140.32432-1-sean.j.christopherson@intel.com> Date: Thu, 21 Mar 2019 15:30:10 +0200 Message-ID: <87lg18e4nx.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, 20 Mar 2019, Sean Christopherson wrote: > Per Thomas' yet-to-be-merged "tip tree handbook"[1], Co-developed-by and > Signed-off-by must be paired together, i.e. the co-authors' SOB mustn't > be scattered willy-nilly, and the author's SOB must be the first SOB > *after* the last Co-developed-by/Signed-off-by pair. Provide an example > to eliminate any ambiguity. > > [1] http://lkml.kernel.org/r/20181107171149.165693799@linutronix.de > > Cc: Thomas Gleixner > Cc: Jorge Ramirez-Ortiz > Cc: Jonathan Cameron > Cc: Joe Perches > Cc: Greg Kroah-Hartman > Cc: Niklas Cassel > Cc: Jonathan Corbet > Signed-off-by: Sean Christopherson > --- > Documentation/process/submitting-patches.rst | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst > index be7d1829c3af..f4b5c4850601 100644 > --- a/Documentation/process/submitting-patches.rst > +++ b/Documentation/process/submitting-patches.rst > @@ -547,8 +547,13 @@ have been included in the discussion. > > A Co-developed-by: states that the patch was also created by another developer > along with the original author. This is useful at times when multiple people > -work on a single patch. Note, this person also needs to have a Signed-off-by: > -line in the patch as well. > +work on a single patch. Note, Co-developed-by: must be accompanied by a > +Signed-off-by: of the co-author(s). All Co-developed-by:/Signed-off-by: pairs > +must precede the Signed-off-by: of the original author. > + > + Co-developed-by: Random Co-Author > + Signed-off-by: Random Co-Author > + Signed-off-by: Original Author Seems to me this suggests Original Author is involved in the patch from start to finish, and then gives Random Co-Author credit as well. IME it's more common for the Original Author to write a patch, and Random Co-Author to take over, finishing the job. Chronologically in this case I'd put the sign-offs the other way round. BR, Jani. > > > 13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes: -- Jani Nikula, Intel Open Source Graphics Center