From: Thomas Gleixner <tglx@linutronix.de>
To: Tianyang Zhang <zhangtianyang@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>
Cc: corbet@lwn.net, alexs@kernel.org, siyanteng@loongson.cn,
kernel@xen0n.name, jiaxun.yang@flygoat.com, gaoliang@loongson.cn,
wangliupu@loongson.cn, lvjianmin@loongson.cn, yijun@loongson.cn,
mhocko@suse.com, akpm@linux-foundation.org,
dianders@chromium.org, maobibo@loongson.cn, xry111@xry111.site,
zhaotianrui@loongson.cn, nathan@kernel.org,
yangtiezhu@loongson.cn, zhoubinbin@loongson.cn,
loongarch@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH V7] LoongArch: Add AVEC irqchip support
Date: Sat, 03 Aug 2024 11:31:37 +0200 [thread overview]
Message-ID: <87msluymti.ffs@tglx> (raw)
In-Reply-To: <cff37371-0692-0db5-cb14-74c519eb1c56@loongson.cn>
Tianyang!
On Sat, Aug 03 2024 at 14:40, Tianyang Zhang wrote:
>
> We consider that since the original extioi-msi is still using the
> legacy-MSI interrupt model at irq-loongson-pch-msi.c, if per-device-MSI
> is directly supported in the AVEC support patch, it will result in the
> simultaneous use of two MSI-interrupt-mode in irq-loongson-pch-msi.c,
> which may seem a bit strange. So we decided to split it into two
> patches, the first one using tlegace-MSI to support AVEC interrupt
> controllers, and the second one will be uniformly modified to use
> per-device-MSI
Adding new code with old functionality to convert it five minutes later
to the modern interface is just backwards.
Convert the existing code over first and then add the new one, no?
Thanks,
tglx
next prev parent reply other threads:[~2024-08-03 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 10:24 [PATCH V7] LoongArch: Add AVEC irqchip support Tianyang Zhang
2024-07-26 15:12 ` Thomas Gleixner
2024-07-30 8:51 ` Huacai Chen
2024-07-30 11:29 ` Thomas Gleixner
2024-08-03 6:40 ` Tianyang Zhang
2024-08-03 9:31 ` Thomas Gleixner [this message]
2024-08-04 2:41 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msluymti.ffs@tglx \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=corbet@lwn.net \
--cc=dianders@chromium.org \
--cc=gaoliang@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=mhocko@suse.com \
--cc=nathan@kernel.org \
--cc=siyanteng@loongson.cn \
--cc=wangliupu@loongson.cn \
--cc=xry111@xry111.site \
--cc=yangtiezhu@loongson.cn \
--cc=yijun@loongson.cn \
--cc=zhangtianyang@loongson.cn \
--cc=zhaotianrui@loongson.cn \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).