Re: [PATCH 6/8] doc: kfigure.py: convert to sphinx.util.logging

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 06 Feb 2024, Mauro Carvalho Chehab <mchehab@kernel.org> wrote:
> Em Tue, 06 Feb 2024 10:57:36 +0200
> Jani Nikula <jani.nikula@intel.com> escreveu:
>
>> On Mon, 05 Feb 2024, Vegard Nossum <vegard.nossum@oracle.com> wrote:
>> > As of commit 3e893e16af55 ("docs: Raise the minimum Sphinx requirement
>> > to 2.4.4"), we can use Sphinx's built-in logging facilities.
>> >
>> > Gotchas:
>> > - remove first argument 'app' from all calls
>> > - instead of (fmt % (args)), use (fmt, args)
>> > - instead of ("<fmt>: " + str) use ("<fmt: %s>", str)  
>> 
>> If you're doing this, why not go directly to f-strings? IMO the above
>> are inferior to it.
>
> Hmm... f-strings require at least python 3.6. Not sure what's the current
> requirement.

[snip]

> Anyway, I would expect that the minimal python version to be listed at:
>
> 	Documentation/process/changes.rst
>
> Apparently, it isn't. IMO, we need to document there that python
> 3.6 is the minimal version required to build the Kernel - or
> at least the documentation.

Yeah, need to document the minimum version, but I'd rather bump it to a
supported version like 3.8 rather than something that reached end of
life two years ago [1].


BR,
Jani.


[1] https://devguide.python.org/versions/


-- 
Jani Nikula, Intel