* [PATCH] docs: cgroup-v1: replace dead CONFIG_MEM_RES_CTRL_SWAP symbol
@ 2023-07-28 10:57 Krzysztof Pawlaczyk
2023-07-28 11:00 ` Lukas Bulwahn
2023-07-31 15:55 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Pawlaczyk @ 2023-07-28 10:57 UTC (permalink / raw)
To: Tejun Heo, Zefan Li, Johannes Weiner, Jonathan Corbet, cgroups,
linux-doc, linux-kernel, lukas.bulwahn
Cc: Krzysztof Pawlaczyk
Commit e55b9f96860f ("mm: memcontrol: drop dead CONFIG_MEMCG_SWAP
config symbol") removed MEMCG_SWAP as it was just a shorthand for
CONFIG_MEMCG && CONFIG_SWAP.
The commit also adjusted the documentation but missed reference to
CONFIG_MEM_RES_CTRL_SWAP, which was the previous name of
CONFIG_MEMCG_SWAP before renaming in commit c255a458055e ("memcg: rename
config variables").
Update the reference to the current state.
Signed-off-by: Krzysztof Pawlaczyk <krzpaw@gmail.com>
---
Documentation/admin-guide/cgroup-v1/memcg_test.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/admin-guide/cgroup-v1/memcg_test.rst b/Documentation/admin-guide/cgroup-v1/memcg_test.rst
index a402359abb99..1f128458ddea 100644
--- a/Documentation/admin-guide/cgroup-v1/memcg_test.rst
+++ b/Documentation/admin-guide/cgroup-v1/memcg_test.rst
@@ -62,7 +62,7 @@ Please note that implementation details can be changed.
At cancel(), simply usage -= PAGE_SIZE.
-Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
+Under below explanation, we assume CONFIG_SWAP=y.
4. Anonymous
============
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] docs: cgroup-v1: replace dead CONFIG_MEM_RES_CTRL_SWAP symbol
2023-07-28 10:57 [PATCH] docs: cgroup-v1: replace dead CONFIG_MEM_RES_CTRL_SWAP symbol Krzysztof Pawlaczyk
@ 2023-07-28 11:00 ` Lukas Bulwahn
2023-07-31 15:55 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2023-07-28 11:00 UTC (permalink / raw)
To: Krzysztof Pawlaczyk
Cc: Tejun Heo, Zefan Li, Johannes Weiner, Jonathan Corbet, cgroups,
linux-doc, linux-kernel
On Fri, Jul 28, 2023 at 12:59 PM Krzysztof Pawlaczyk <krzpaw@gmail.com> wrote:
>
> Commit e55b9f96860f ("mm: memcontrol: drop dead CONFIG_MEMCG_SWAP
> config symbol") removed MEMCG_SWAP as it was just a shorthand for
> CONFIG_MEMCG && CONFIG_SWAP.
>
> The commit also adjusted the documentation but missed reference to
> CONFIG_MEM_RES_CTRL_SWAP, which was the previous name of
> CONFIG_MEMCG_SWAP before renaming in commit c255a458055e ("memcg: rename
> config variables").
>
> Update the reference to the current state.
>
Thanks for the cleanup.
Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Lukas
> Signed-off-by: Krzysztof Pawlaczyk <krzpaw@gmail.com>
> ---
> Documentation/admin-guide/cgroup-v1/memcg_test.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/cgroup-v1/memcg_test.rst b/Documentation/admin-guide/cgroup-v1/memcg_test.rst
> index a402359abb99..1f128458ddea 100644
> --- a/Documentation/admin-guide/cgroup-v1/memcg_test.rst
> +++ b/Documentation/admin-guide/cgroup-v1/memcg_test.rst
> @@ -62,7 +62,7 @@ Please note that implementation details can be changed.
>
> At cancel(), simply usage -= PAGE_SIZE.
>
> -Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
> +Under below explanation, we assume CONFIG_SWAP=y.
>
> 4. Anonymous
> ============
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] docs: cgroup-v1: replace dead CONFIG_MEM_RES_CTRL_SWAP symbol
2023-07-28 10:57 [PATCH] docs: cgroup-v1: replace dead CONFIG_MEM_RES_CTRL_SWAP symbol Krzysztof Pawlaczyk
2023-07-28 11:00 ` Lukas Bulwahn
@ 2023-07-31 15:55 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2023-07-31 15:55 UTC (permalink / raw)
To: Krzysztof Pawlaczyk, Tejun Heo, Zefan Li, Johannes Weiner,
cgroups, linux-doc, linux-kernel, lukas.bulwahn
Cc: Krzysztof Pawlaczyk
Krzysztof Pawlaczyk <krzpaw@gmail.com> writes:
> Commit e55b9f96860f ("mm: memcontrol: drop dead CONFIG_MEMCG_SWAP
> config symbol") removed MEMCG_SWAP as it was just a shorthand for
> CONFIG_MEMCG && CONFIG_SWAP.
>
> The commit also adjusted the documentation but missed reference to
> CONFIG_MEM_RES_CTRL_SWAP, which was the previous name of
> CONFIG_MEMCG_SWAP before renaming in commit c255a458055e ("memcg: rename
> config variables").
>
> Update the reference to the current state.
>
> Signed-off-by: Krzysztof Pawlaczyk <krzpaw@gmail.com>
> ---
> Documentation/admin-guide/cgroup-v1/memcg_test.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/cgroup-v1/memcg_test.rst b/Documentation/admin-guide/cgroup-v1/memcg_test.rst
> index a402359abb99..1f128458ddea 100644
> --- a/Documentation/admin-guide/cgroup-v1/memcg_test.rst
> +++ b/Documentation/admin-guide/cgroup-v1/memcg_test.rst
> @@ -62,7 +62,7 @@ Please note that implementation details can be changed.
>
> At cancel(), simply usage -= PAGE_SIZE.
>
> -Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
> +Under below explanation, we assume CONFIG_SWAP=y.
>
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-31 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 10:57 [PATCH] docs: cgroup-v1: replace dead CONFIG_MEM_RES_CTRL_SWAP symbol Krzysztof Pawlaczyk
2023-07-28 11:00 ` Lukas Bulwahn
2023-07-31 15:55 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).