From: Jonathan Corbet <corbet@lwn.net>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: linux-doc@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH] docs/driver-api/miscellaneous: Remove kernel-doc of serial_core.c
Date: Mon, 21 Nov 2022 14:01:16 -0700 [thread overview]
Message-ID: <87o7t09g4j.fsf@meer.lwn.net> (raw)
In-Reply-To: <9f23e62c-1401-cf58-f99b-fa804366cd4c@gmail.com>
Akira Yokosawa <akiyks@gmail.com> writes:
> Hi Jon,
>
> On Wed, 9 Nov 2022 23:45:06 +0900, Akira Yokosawa wrote:
>> Hi Jon,
>>
>> On Wed, 2 Nov 2022 20:48:01 +0900, Akira Yokosawa wrote:
>>> Since merge of tty-6.0-rc1, "make htmldocs" with Sphinx >=3.1 emits
>>> a bunch of warnings indicating duplicate kernel-doc comments from
>>> drivers/tty/serial/serial_core.c.
>>>
>>> This is due to the kernel-doc directive for serial_core.c in
>>> serial/drivers.rst added in the merge. It conflicts with an existing
>>> kernel-doc directive in miscellaneous.rst.
>>>
>>> Remove the latter directive and resolve the duplicates.
>>>
>>> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
>>> Fixes: 607ca0f742b7 ("Merge tag 'tty-6.0-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty")
>>> Cc: stable@vger.kernel.org # 6.0
>>> Cc: Jiri Slaby <jslaby@suse.cz>
>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> ---
> [...]
>>
>> Jon, Greg has added this to his tty tree and (hopefully) it will
>> soon land Linus' tree (v6.1-rcX).
>> I'll ask you a back-merge once it happens.
>
> This change has landed at v6.1-rc6 as commit 3ec17cb325ac
> ("docs/driver-api/miscellaneous: Remove kernel-doc of serial_core.c").
> Can you please consider backmerging v6.1-rc6?
> There is another fix landed at v6.1-rc5 which fixed another duplicate
> kernel-doc, commit c18c20f16219 ("mm, slab: remove duplicate kernel-doc
> comment for ksize()") authored by Vlastimil.
So the purpose of this backmerge would be just to get rid of a few
warnings in docs-next for the next few weeks? Given the jaundiced eye
with which Linus looks at backmerges, I'm inclined to just wait and let
it all settle out during the merge window. Is there any work that would
be impeded by not doing that merge now?
Thanks,
jon
next prev parent reply other threads:[~2022-11-21 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 11:48 [PATCH] docs/driver-api/miscellaneous: Remove kernel-doc of serial_core.c Akira Yokosawa
2022-11-03 6:35 ` Jiri Slaby
2022-11-09 14:45 ` Akira Yokosawa
2022-11-21 13:46 ` Akira Yokosawa
2022-11-21 20:59 ` Jonathan Corbet
2022-11-21 21:01 ` Jonathan Corbet [this message]
2022-11-21 23:10 ` Akira Yokosawa
2022-11-21 23:29 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7t09g4j.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akiyks@gmail.com \
--cc=linux-doc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).