From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 318EDC07E9D for ; Mon, 19 Jul 2021 14:45:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A16E6113E for ; Mon, 19 Jul 2021 14:45:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232531AbhGSOE6 (ORCPT ); Mon, 19 Jul 2021 10:04:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27213 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241149AbhGSOE5 (ORCPT ); Mon, 19 Jul 2021 10:04:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626705937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UyRUtFYmxkhkvXTjyXTCYNWwlpNIWrI0mswGdMQlRtQ=; b=Wdu1east2v0SBdCNc0fMzGXRTpVgXkf0207PnYYEshUPqpWAdi7ymS40+dgFwkxKWJ3uGn 9pXwJAvJ1tjOVPmYK37/jYe3aYeJ/3qSAYa88ITq1jzoq//msdF8SPAUB0eCpBsMAztP9s EuuM5aTIUkZQSjKTjqIurtSoc6VXNsc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-9dUSJg9oPkyuOzaJb7ANGg-1; Mon, 19 Jul 2021 10:45:35 -0400 X-MC-Unique: 9dUSJg9oPkyuOzaJb7ANGg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E37FC804140; Mon, 19 Jul 2021 14:45:31 +0000 (UTC) Received: from localhost (ovpn-112-158.ams2.redhat.com [10.36.112.158]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F18E760CC9; Mon, 19 Jul 2021 14:45:23 +0000 (UTC) From: Cornelia Huck To: Jason Gunthorpe , David Airlie , Tony Krowiak , Alex Williamson , Christian Borntraeger , Jonathan Corbet , Daniel Vetter , Diana Craciun , dri-devel@lists.freedesktop.org, Eric Auger , Eric Farman , Harald Freudenberger , Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, Kirti Wankhede , linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Matthew Rosato , Peter Oberparleiter , Halil Pasic , Rodrigo Vivi , Vineeth Vijayan , Zhenyu Wang , Zhi Wang Cc: "Raj, Ashok" , Christoph Hellwig , Leon Romanovsky , Max Gurtovoy , Yishai Hadas Subject: Re: [PATCH 10/13] vfio/mbochs: Fix close when multiple device FDs are open In-Reply-To: <10-v1-eaf3ccbba33c+1add0-vfio_reflck_jgg@nvidia.com> Organization: Red Hat GmbH References: <10-v1-eaf3ccbba33c+1add0-vfio_reflck_jgg@nvidia.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Mon, 19 Jul 2021 16:45:22 +0200 Message-ID: <87o8ay9xbx.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, Jul 14 2021, Jason Gunthorpe wrote: > mbochs_close() iterates over global device state and frees it. Currently > this is done every time a device FD is closed, but if multiple device FDs > are open this could corrupt other still active FDs. > > Change this to use close_device() so it only runs on the last close. > > Signed-off-by: Jason Gunthorpe > --- > samples/vfio-mdev/mbochs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck