Linux Documentation
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	linux-doc@vger.kernel.org, feng.tang@linux.alibaba.com,
	pmladek@suse.com, include@grrlz.net
Cc: skhan@linuxfoundation.org, rdunlap@infradead.org,
	andriy.shevchenko@linux.intel.com, kees@kernel.org,
	tony.luck@intel.com, linux-kernel@vger.kernel.org,
	kernel-dev@igalia.com, kernel@gpiccoli.net, gpiccoli@igalia.com
Subject: Re: [PATCH V2] docs: panic: Disclaimer about console verbosity when using panic_print with pstore
Date: Mon, 24 Aug 2026 11:13:38 -0600	[thread overview]
Message-ID: <87pkz7xwzh.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260819183419.2203903-1-gpiccoli@igalia.com>

"Guilherme G. Piccoli" <gpiccoli@igalia.com> writes:

> Users of panic_print / panic_sys_info are usually aware of the potentially
> huge amount of information displayed with such options - their goal by
> using them is indeed to dump more information during panic!
>
> What might come unnoticed at first is the impact that the console_verbose()
> call on panic path has, specially in cases that users rely on pstore as
> a means to collect the panic logs. Recent experience shows that dumping
> all tasks in an ARM64 system (with qcom_geni tty driver) gets a 2 minute
> delay on panic time due to writing such information to console. But in
> that case, pstore was used, so there was no need for console printing,
> and suppressing that reduced the full time to less than 0.5 second.
>
> The option "printk.console_no_auto_verbose" aims exactly at this use
> case: avoid automatically increasing the loglevel during panic path.
> So, let's officially document this to avoid users wasting their time
> either on long panic printing or debugging the panic delays.
>
> While at it, improve the readability of the panic_print text, by
> adding some line breaks.
>
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Reviewed-by: Bradley Morgan <include@grrlz.net>
> Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>
>
> V2:
> - Added line breaks as per Petr's suggestion (with some text improvements
>   as well) - thanks Petr!
>
> - Added review tags - thanks Feng Tang and Bradley, feel free to check
>   again given we added the line breaks, etc.
>
> V1 link: https://lore.kernel.org/r/20260805205026.1699568-1-gpiccoli@igalia.com/
>
>
>  .../admin-guide/kernel-parameters.txt         | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)

Applied, thanks.

jon

      parent reply	other threads:[~2026-08-24 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 18:31 [PATCH V2] docs: panic: Disclaimer about console verbosity when using panic_print with pstore Guilherme G. Piccoli
2026-08-19 19:03 ` Bradley Morgan
2026-08-20  9:16 ` Petr Mladek
2026-08-24 17:13 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pkz7xwzh.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=feng.tang@linux.alibaba.com \
    --cc=gpiccoli@igalia.com \
    --cc=include@grrlz.net \
    --cc=kees@kernel.org \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox