From: Thomas Gleixner <tglx@linutronix.de>
To: Huacai Chen <chenhuacai@kernel.org>,
Tianyang Zhang <zhangtianyang@loongson.cn>
Cc: kernel@xen0n.name, corbet@lwn.net, alexs@kernel.org,
si.yanteng@linux.dev, jiaxun.yang@flygoat.com,
peterz@infradead.org, wangliupu@loongson.cn,
lvjianmin@loongson.cn, maobibo@loongson.cn,
siyanteng@cqsoftware.com.cn, gaosong@loongson.cn,
yangtiezhu@loongson.cn, loongarch@lists.linux.dev,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] irq/irq-loongarch-ir:Add Redirect irqchip support
Date: Mon, 03 Mar 2025 22:28:26 +0100 [thread overview]
Message-ID: <87plixby85.ffs@tglx> (raw)
In-Reply-To: <CAAhV-H4G2qk69LF41VFoFgd7ZBAqAFB=hA7PMkaxXdNVEX-WyA@mail.gmail.com>
On Mon, Mar 03 2025 at 22:34, Huacai Chen wrote:
> On Mon, Mar 3, 2025 at 6:15 PM Tianyang Zhang <zhangtianyang@loongson.cn> wrote:
>> +static const struct irq_domain_ops loongarch_redirect_domain_ops = {
>> + .alloc = loongarch_irq_redirect_alloc,
>> + .free = loongarch_irq_redirect_free,
>> + .select = msi_lib_irq_domain_select,
>> +};
> For consistency, please use:
> static const struct irq_domain_ops redirect_domain_ops = {
> .alloc = redirect_domain_alloc,
> .free = redirect_domain_free,
> .select = msi_lib_irq_domain_select,
> };
This formatting requirement applies to all structures in this patch. See
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#coding-style-notes
for further information.
Thanks,
tglx
next prev parent reply other threads:[~2025-03-03 21:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 10:15 [PATCH 0/2] Loongarch irq-redirect supprot Tianyang Zhang
2025-03-03 10:15 ` [PATCH 1/2] Docs/LoongArch: Add Advanced Extended-Redirect IRQ model description Tianyang Zhang
2025-03-03 13:36 ` Huacai Chen
2025-03-06 2:09 ` Tianyang Zhang
2025-03-03 10:15 ` [PATCH 2/2] irq/irq-loongarch-ir:Add Redirect irqchip support Tianyang Zhang
2025-03-03 14:34 ` Huacai Chen
2025-03-03 21:28 ` Thomas Gleixner [this message]
2025-03-06 2:07 ` Tianyang Zhang
2025-03-06 2:06 ` Tianyang Zhang
2025-03-04 11:24 ` kernel test robot
2025-03-05 14:47 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-03-17 8:22 [PATCH v1 0/2] Loongarch irq-redirect supprot Tianyang Zhang
2025-03-17 8:22 ` [PATCH 2/2] irq/irq-loongarch-ir:Add Redirect irqchip support Tianyang Zhang
2025-03-19 5:55 ` Tianyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plixby85.ffs@tglx \
--to=tglx@linutronix.de \
--cc=alexs@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=gaosong@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=peterz@infradead.org \
--cc=si.yanteng@linux.dev \
--cc=siyanteng@cqsoftware.com.cn \
--cc=wangliupu@loongson.cn \
--cc=yangtiezhu@loongson.cn \
--cc=zhangtianyang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox