From: Jonathan Corbet <corbet@lwn.net>
To: "Philipp Stanner" <pstanner@redhat.com>,
"Mark Brown" <broonie@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Philipp Stanner" <pstanner@redhat.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH RESEND] Documentation: devres: fix error about PCI devres
Date: Fri, 16 Aug 2024 16:33:50 -0600 [thread overview]
Message-ID: <87plq8hzch.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20240809095248.14220-2-pstanner@redhat.com>
Philipp Stanner <pstanner@redhat.com> writes:
> The documentation states that pcim_enable_device() will make "all PCI
> ops" managed. This is totally false, only a small subset of PCI
> functions become managed that way. Implicating otherwise has caused at
> least one bug so far, namely in commit 8558de401b5f ("drm/vboxvideo: use
> managed pci functions").
>
> Change the function summary so the functions dangerous behavior becomes
> obvious.
>
> Signed-off-by: Philipp Stanner <pstanner@redhat.com>
> ---
> +CC PCI and Bjorn.
>
> Bjorn, btw. neither PCI nor you are printed by getmaintainers for the
> touched document. Possibly one might want to think about fixing that
> somehow.
> But I don't think it's a huge deal.
> ---
> Documentation/driver-api/driver-model/devres.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
jon
prev parent reply other threads:[~2024-08-16 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 9:52 [PATCH RESEND] Documentation: devres: fix error about PCI devres Philipp Stanner
2024-08-09 18:37 ` Bjorn Helgaas
2024-08-16 22:33 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plq8hzch.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pstanner@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox