From: Jonathan Corbet <corbet@lwn.net>
To: Lasse Collin <lasse.collin@tukaani.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Lasse Collin <lasse.collin@tukaani.org>,
Sam James <sam@gentoo.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 08/16] docs: Add XZ_EXTERN to c_id_attributes
Date: Sun, 21 Jul 2024 17:16:33 -0600 [thread overview]
Message-ID: <87r0bms5da.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20240721133633.47721-9-lasse.collin@tukaani.org>
Lasse Collin <lasse.collin@tukaani.org> writes:
> include/linux/xz.h uses XZ_EXTERN in function prototypes. It's needed in
> the preboot code. Adding XZ_EXTERN c_id_attributes silences warnings and
> makes the intradocument links to the xz_dec functions work.
>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Reviewed-by: Sam James <sam@gentoo.org>
> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
> ---
> Documentation/conf.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/conf.py b/Documentation/conf.py
> index 0c2205d536b3..2fc1fea858e1 100644
> --- a/Documentation/conf.py
> +++ b/Documentation/conf.py
> @@ -123,6 +123,9 @@ if major >= 3:
>
> # include/linux/btf.h
> "__bpf_kfunc",
> +
> + # include/linux/xz.h
> + "XZ_EXTERN",
> ]
I spent a little while trying to figure out why we need XZ_EXTERN at all
but lost in the #includes... Oh well. For the purposes of the docs
build:
Acked-by: Jonathan Corbet <corbet@lwn.net>
Thanks,
jon
next prev parent reply other threads:[~2024-07-21 23:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240721133633.47721-1-lasse.collin@tukaani.org>
2024-07-21 13:36 ` [PATCH v2 05/16] xz: Fix kernel-doc formatting errors in xz.h Lasse Collin
2024-07-22 2:38 ` Randy Dunlap
2024-07-21 13:36 ` [PATCH v2 06/16] xz: Improve the MicroLZMA kernel-doc " Lasse Collin
2024-07-21 13:36 ` [PATCH v2 07/16] xz: Documentation/staging/xz.rst: Revise thoroughly Lasse Collin
2024-07-22 3:19 ` Randy Dunlap
2024-07-21 13:36 ` [PATCH v2 08/16] docs: Add XZ_EXTERN to c_id_attributes Lasse Collin
2024-07-21 23:16 ` Jonathan Corbet [this message]
2024-07-23 17:54 ` Lasse Collin
2024-07-24 11:05 ` [PATCH v2 17/16] xz: Remove XZ_EXTERN and extern from functions Lasse Collin
2024-07-24 12:44 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0bms5da.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=akpm@linux-foundation.org \
--cc=lasse.collin@tukaani.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).