From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41FB2C433FE for ; Fri, 25 Mar 2022 19:47:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231616AbiCYTtJ (ORCPT ); Fri, 25 Mar 2022 15:49:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232713AbiCYTsq (ORCPT ); Fri, 25 Mar 2022 15:48:46 -0400 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1F0C2B2050; Fri, 25 Mar 2022 12:32:13 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:35::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 158632C3; Fri, 25 Mar 2022 19:32:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 158632C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1648236733; bh=49jpW2WxwfDWgFFg2FEAQXR26EWHs8pIegLvOIkxseo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bAxEoivqRB+DOXFovPcLu/16Ktwh00jBNgPNhyGIbRappbFfTiVDnz18bGe2pbbvG QDQ4bYVfnLlfSXAqzTtAEKlqSgabmb/JMxNHKmANeQ7DrtV+6UHg0UkTgMUsFCuT4v zz2ydPArc9/TpTtrYbukEKfnVBzbbCYR2T09PNzn0RVS9RGs82kwVkNbuvLUES7Hq1 tpSKN8+FVzL9c24J8rNQ/Kqitxc7OncOrI+cS/Q4RrQE3ZnoHQLCHg4YPtXh2LUqhs aRX0doy8aB0ckQk86IecEt/zAX6lzpy23lNkcMV2ZEr29OlEGskrq4sLEM3oVgw0U2 lSgxTC7Y6+E4w== From: Jonathan Corbet To: "Guilherme G. Piccoli" , linux-doc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, gpiccoli@igalia.com, kernel@gpiccoli.net, Thomas Gleixner Subject: Re: [PATCH] Documentation: Fix duplicate statement about raw_spinlock_t type In-Reply-To: <20220321144133.49804-1-gpiccoli@igalia.com> References: <20220321144133.49804-1-gpiccoli@igalia.com> Date: Fri, 25 Mar 2022 13:32:12 -0600 Message-ID: <87r16peslf.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org "Guilherme G. Piccoli" writes: > Unless it was duplicate on purpose, to emphasize that a raw_spinlock_t > is always a spinning lock regardless of PREEMPT_RT or kernel config, > it's a bit odd that this text is duplicate. So, this patch just clean > it up, keeping the consistency with the other sections of the text. > > Cc: Thomas Gleixner > Fixes: 919e9e6395cf ("Documentation: Add lock ordering and nesting documentation") > Signed-off-by: Guilherme G. Piccoli > --- > Documentation/locking/locktypes.rst | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst > index bfa75ea1b66a..9933faad4771 100644 > --- a/Documentation/locking/locktypes.rst > +++ b/Documentation/locking/locktypes.rst > @@ -211,9 +211,6 @@ raw_spinlock_t and spinlock_t > raw_spinlock_t > -------------- > > -raw_spinlock_t is a strict spinning lock implementation regardless of the > -kernel configuration including PREEMPT_RT enabled kernels. > - > raw_spinlock_t is a strict spinning lock implementation in all kernels, > including PREEMPT_RT kernels. Use raw_spinlock_t only in real critical > core code, low-level interrupt handling and places where disabling I don't think that was intentional. Applied, thanks. For future reference, a far better changelog would have been something like: Remove the duplicated sentence from locktypes.rst Thanks, jon