Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Geert Uytterhoeven]

Hi Amitabh,

Thanks for your patch!

On Thu, 5 Feb 2026 at 13:09, Amitabh Srivastava <amitabh@amidevlab.com> wrote:
> Update http link to the documentation about how to add a kernel.org UID to
> the maintainer's key. Add missing SPDX-License-Identifier to fix a
> checkpatch warning.

The first sentence states the obvious, but does not explain the
rationale behind this change.  Why should it be changed?  Both the
old and the new URL work.

> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>

> --- a/Documentation/process/maintainer-pgp-guide.rst
> +++ b/Documentation/process/maintainer-pgp-guide.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  .. _pgpguide:
>
>  ===========================
> @@ -864,7 +866,7 @@ don't already have them)::
>  If you have a kernel.org account, then you should `add the kernel.org
>  UID to your key`_ to make WKD more useful to other kernel developers.
>
> -.. _`add the kernel.org UID to your key`: https://korg.wiki.kernel.org/userdoc/mail#adding_a_kernelorg_uid_to_your_pgp_key
> +.. _`add the kernel.org UID to your key`: https://korg.docs.kernel.org/mail.html#adding-a-kernel-org-uid-to-your-pgp-key
>
>  Web of Trust (WOT) vs. Trust on First Use (TOFU)
>  ------------------------------------------------

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Amitabh]

Hi Geert,

Hope this clarifies.

> On 5 Feb 2026, at 6:53 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> 
> Hi Amitabh,
> 
> Thanks for your patch!
> 
> On Thu, 5 Feb 2026 at 13:09, Amitabh Srivastava <amitabh@amidevlab.com> wrote:
>> Update http link to the documentation about how to add a kernel.org UID to
>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>> checkpatch warning.
> 
> > The first sentence states the obvious, but does not explain the
> > rationale behind this change.  Why should it be changed?  Both the
> > old and the new URL work.

> The old URL no longer points to the correct page having mentioned information.
> [Old URL]: Simply redirects to 'https://korg.docs.kernel.org/', which doesn't have any information on how to add the kernel.org UID to your PGP key.
> [New URL]: Precisely opens the respective page at the anchor for the respective section 'Adding a kernel.org UID to your PGP key'.

>> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
> 
>> --- a/Documentation/process/maintainer-pgp-guide.rst
>> +++ b/Documentation/process/maintainer-pgp-guide.rst
>> @@ -1,3 +1,5 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> .. _pgpguide:
>> 
>> ===========================
>> @@ -864,7 +866,7 @@ don't already have them)::
>> If you have a kernel.org account, then you should `add the kernel.org
>> UID to your key`_ to make WKD more useful to other kernel developers.
>> 
>> -.. _`add the kernel.org UID to your key`: https://korg.wiki.kernel.org/userdoc/mail#adding_a_kernelorg_uid_to_your_pgp_key
>> +.. _`add the kernel.org UID to your key`: https://korg.docs.kernel.org/mail.html#adding-a-kernel-org-uid-to-your-pgp-key
>> 
>> Web of Trust (WOT) vs. Trust on First Use (TOFU)
>> ------------------------------------------------
> 
> Gr{oetje,eeting}s,
> 
>                        Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                -- Linus TorvaldsThanks

> Regards

> Amitabh

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Jonathan Corbet]

Amitabh Srivastava <amitabh@amidevlab.com> writes:

> Update http link to the documentation about how to add a kernel.org UID to
> the maintainer's key. Add missing SPDX-License-Identifier to fix a
> checkpatch warning.
>
> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
> ---
>  Documentation/process/maintainer-pgp-guide.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
> index b6919bf606c3..1e4d885dc784 100644
> --- a/Documentation/process/maintainer-pgp-guide.rst
> +++ b/Documentation/process/maintainer-pgp-guide.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +

Do you know that was the intended license for this file?  We need to be
careful about putting license declarations on other people's work.

Thanks,

jon

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Amitabh]

Hi Jon,

> On 5 Feb 2026, at 8:19 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> 
> Amitabh Srivastava <amitabh@amidevlab.com> writes:
> 
>> Update http link to the documentation about how to add a kernel.org UID to
>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>> checkpatch warning.
>> 
>> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
>> ---
>> Documentation/process/maintainer-pgp-guide.rst | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
>> index b6919bf606c3..1e4d885dc784 100644
>> --- a/Documentation/process/maintainer-pgp-guide.rst
>> +++ b/Documentation/process/maintainer-pgp-guide.rst
>> @@ -1,3 +1,5 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
> 
> Do you know that was the intended license for this file?  We need to be
> careful about putting license declarations on other people's work.
> 
Yes, The Linux kernel documentation is typically licensed under GPL-2.0.
Other files in the directory contain the same 'SPDX-License-Identifier' as well.
However, I have added this just to satisfy checkpatch.pl requirement, which
checks for missing license information in documentation files. Let me know if
you think otherwise.

> Thanks,
> 
> jon

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Jonathan Corbet]

Amitabh <amitabh@amidevlab.com> writes:

> Hi Jon,
>
>> On 5 Feb 2026, at 8:19 PM, Jonathan Corbet <corbet@lwn.net> wrote:
>> 
>> Amitabh Srivastava <amitabh@amidevlab.com> writes:
>> 
>>> Update http link to the documentation about how to add a kernel.org UID to
>>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>>> checkpatch warning.
>>> 
>>> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
>>> ---
>>> Documentation/process/maintainer-pgp-guide.rst | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
>>> index b6919bf606c3..1e4d885dc784 100644
>>> --- a/Documentation/process/maintainer-pgp-guide.rst
>>> +++ b/Documentation/process/maintainer-pgp-guide.rst
>>> @@ -1,3 +1,5 @@
>>> +.. SPDX-License-Identifier: GPL-2.0
>>> +
>> 
>> Do you know that was the intended license for this file?  We need to be
>> careful about putting license declarations on other people's work.
>> 
> Yes, The Linux kernel documentation is typically licensed under GPL-2.0.

I am aware of kernel documentation practices :)  "Typically licensed"
does not tell you what any individual contributor intended, though.
*Probably* that tag is OK, but you should really consult with the
original author of that page to ask what their intent was.

> Other files in the directory contain the same 'SPDX-License-Identifier' as well.
> However, I have added this just to satisfy checkpatch.pl requirement, which
> checks for missing license information in documentation files. Let me know if
> you think otherwise.

Checkpatch makes suggestions, not requirements.  All files in the kernel
should have SPDX lines, but they need to be the correct ones, not just
somebody's guess.

Thanks,

jon

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Amitabh]

Hi Jon,


> On 5 Feb 2026, at 9:00 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> 
> Amitabh <amitabh@amidevlab.com> writes:
> 
>> Hi Jon,
>> 
>>> On 5 Feb 2026, at 8:19 PM, Jonathan Corbet <corbet@lwn.net> wrote:
>>> 
>>> Amitabh Srivastava <amitabh@amidevlab.com> writes:
>>> 
>>>> Update http link to the documentation about how to add a kernel.org UID to
>>>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>>>> checkpatch warning.
>>>> 
>>>> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
>>>> ---
>>>> Documentation/process/maintainer-pgp-guide.rst | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>> 
>>>> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
>>>> index b6919bf606c3..1e4d885dc784 100644
>>>> --- a/Documentation/process/maintainer-pgp-guide.rst
>>>> +++ b/Documentation/process/maintainer-pgp-guide.rst
>>>> @@ -1,3 +1,5 @@
>>>> +.. SPDX-License-Identifier: GPL-2.0
>>>> +
>>> 
>>> Do you know that was the intended license for this file?  We need to be
>>> careful about putting license declarations on other people's work.
>>> 
>> Yes, The Linux kernel documentation is typically licensed under GPL-2.0.
> 
> I am aware of kernel documentation practices :)  "Typically licensed"
> does not tell you what any individual contributor intended, though.
> *Probably* that tag is OK, but you should really consult with the
> original author of that page to ask what their intent was.

You are absolutely correct. In fact, the original author, Konstantin Ryabitsev,
(in TO here) responded to my v1 patch in the affirmative regarding the changes.
(https://lore.kernel.org/all/177006480695.901069.1641199463436529014@lemur/)

> 
>> Other files in the directory contain the same 'SPDX-License-Identifier' as well.
>> However, I have added this just to satisfy checkpatch.pl requirement, which
>> checks for missing license information in documentation files. Let me know if
>> you think otherwise.
> 
> Checkpatch makes suggestions, not requirements.  All files in the kernel
> should have SPDX lines, but they need to be the correct ones, not just
> somebody's guess.
> 
I went with the common practice, but, can wait for konstantin to endorse this.

> Thanks,
> 
> jon

Regards
Amitabh

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Konstantin Ryabitsev]

On Fri, Feb 06, 2026 at 12:02:00AM +0530, Amitabh wrote:
> > I am aware of kernel documentation practices :)  "Typically licensed"
> > does not tell you what any individual contributor intended, though.
> > *Probably* that tag is OK, but you should really consult with the
> > original author of that page to ask what their intent was.
> 
> You are absolutely correct. In fact, the original author, Konstantin Ryabitsev,
> (in TO here) responded to my v1 patch in the affirmative regarding the changes.
> (https://lore.kernel.org/all/177006480695.901069.1641199463436529014@lemur/)

Yes, that matches the intended license.

-K

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Konstantin Ryabitsev]

On Thu, Feb 5, 2026, at 06:55, Amitabh Srivastava wrote:
> Update http link to the documentation about how to add a kernel.org UID to
> the maintainer's key. Add missing SPDX-License-Identifier to fix a
> checkpatch warning.

No objections from me, but please check with other reviewers if they want another revision.

Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

-K

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Jonathan Corbet]

"Konstantin Ryabitsev" <mricon@kernel.org> writes:

> On Thu, Feb 5, 2026, at 06:55, Amitabh Srivastava wrote:
>> Update http link to the documentation about how to add a kernel.org UID to
>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>> checkpatch warning.
>
> No objections from me, but please check with other reviewers if they want another revision.
>
> Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

I think we've probably done enough rounds on this one :)

Thanks,

jon

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Amitabh]

Hi Jon,

Hope my patch gets accepted for commit.


> On 6 Feb 2026, at 9:34 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> 
> "Konstantin Ryabitsev" <mricon@kernel.org> writes:
> 
>> On Thu, Feb 5, 2026, at 06:55, Amitabh Srivastava wrote:
>>> Update http link to the documentation about how to add a kernel.org UID to
>>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>>> checkpatch warning.
>> 
>> No objections from me, but please check with other reviewers if they want another revision.
>> 
>> Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
> 
> I think we've probably done enough rounds on this one :)
> 
> Thanks,
> 
> Jon

Regards
Amitabh

Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link

[Jonathan Corbet]

Amitabh Srivastava <amitabh@amidevlab.com> writes:

> Update http link to the documentation about how to add a kernel.org UID to
> the maintainer's key. Add missing SPDX-License-Identifier to fix a
> checkpatch warning.
>
> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
> ---
>  Documentation/process/maintainer-pgp-guide.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
> index b6919bf606c3..1e4d885dc784 100644
> --- a/Documentation/process/maintainer-pgp-guide.rst
> +++ b/Documentation/process/maintainer-pgp-guide.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  .. _pgpguide:
>  
>  ===========================
> @@ -864,7 +866,7 @@ don't already have them)::
>  If you have a kernel.org account, then you should `add the kernel.org
>  UID to your key`_ to make WKD more useful to other kernel developers.
>  
> -.. _`add the kernel.org UID to your key`: https://korg.wiki.kernel.org/userdoc/mail#adding_a_kernelorg_uid_to_your_pgp_key
> +.. _`add the kernel.org UID to your key`: https://korg.docs.kernel.org/mail.html#adding-a-kernel-org-uid-to-your-pgp-key
>  

Applied, thanks.

jon