From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC771E520C for ; Fri, 19 Sep 2025 12:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758285472; cv=none; b=e9qG/IEH3wEGwygMbVcOftqgOCTjCRDs35Nkmy7tXb63ObVMtJtEyb0pbUgdpA+qu4AEpQ43aPGVSeH06GxsJaGss5vGIYm79MzQTg0UEsZSKTFhdlOaTHLEope1rrq6ANXoBMtC5bpzNV5JNXiINZCQUwK4Xx7D2cwRCRS//Qc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758285472; c=relaxed/simple; bh=E071kAR9Cwiv4tprzrsQd0Wm1nTgm4cnT1ggYiCLipw=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=HyjfjyHwABmyEcUp9apd3qhmxaomQN4gMbJ2S9sIcT00fYd7bJSNuF/wnSEw28iwiJpTW2+Rg07Mnj0PvSQS3LYDIlYTE5EJGOnqOEABzHoFu+qUHY7mQen6TUnvdPUZCkAmhPjzR27F6kpbsiqbaUjFfR2j3YyI2LVYTXAMraA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=hOSWJ7U/; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=8OLgf1Zr; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=byjqooEg; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=MqqkmBtT; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="hOSWJ7U/"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="8OLgf1Zr"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="byjqooEg"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="MqqkmBtT" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0C65B336B4; Fri, 19 Sep 2025 12:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1758285469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C6GkLf705dTHn7tuGiBKNFNBqf28JhNLc1I8EUzcjUw=; b=hOSWJ7U/8dYXoWnNnn6X1odf4EaTM1yIxkWtxLQyXvMLITi+f4+C4I1ePsLkj1CUAGcDSl nZkhM9Y071HN0IysIX3E1/H+iPUCBDYwS3C9nDCV1SeMZa1xKCBacEnE4Gy6M4f41UfzKb lvlPCUWYrFzWJiSH2VtWPCjUlLW0H/E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1758285469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C6GkLf705dTHn7tuGiBKNFNBqf28JhNLc1I8EUzcjUw=; b=8OLgf1Zr3oOREDInTDBQpw63Fk0HgEYhgQ+PTEVMQ2ke3lA8G+VSPyT+iQYOcvWZ9yTvqK lOE0k0Js6yQa2WBw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1758285468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C6GkLf705dTHn7tuGiBKNFNBqf28JhNLc1I8EUzcjUw=; b=byjqooEgqNWSMVsab6feLYA1L0bmd4qz+qeiUHe840D2iqdHcwkEkeGmzxpp5PbYnTHPsS 4wL7PGLo/OstegEJr4JNmgHs8ylY2601/bPC9HkAx1IsoaO1M7/nxE628XdUbb37oH2CmI CVkjwiTRcN70uJccnRLUTmCJR6rvaTo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1758285468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C6GkLf705dTHn7tuGiBKNFNBqf28JhNLc1I8EUzcjUw=; b=MqqkmBtTVWRKWn03tZcXSpkWq5S4ylxtoNpOKQpTS7h04IWTuiltf9fwfMtZvoXP6oUcEn GoH2t3o13iLcFXDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7B3C613A39; Fri, 19 Sep 2025 12:37:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Cd2nHJtOzWgofgAAD6G6ig (envelope-from ); Fri, 19 Sep 2025 12:37:47 +0000 Date: Fri, 19 Sep 2025 14:37:47 +0200 Message-ID: <87segi8vok.wl-tiwai@suse.de> From: Takashi Iwai To: cryolitia@uniontech.com Cc: Jaroslav Kysela , Takashi Iwai , Jonathan Corbet , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-sound@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Mingcong Bai , Kexy Biscuit , Nie Cheng , Zhan Jun , Feng Yuan , qaqland , kernel@uniontech.com, linux-modules@vger.kernel.org Subject: Re: [PATCH v4 2/5] param: export param_array related functions In-Reply-To: <20250918-sound-v4-2-82cf8123d61c@uniontech.com> References: <20250918-sound-v4-0-82cf8123d61c@uniontech.com> <20250918-sound-v4-2-82cf8123d61c@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Level: X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[20]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid] X-Spam-Flag: NO X-Spam-Score: -3.30 On Thu, 18 Sep 2025 11:24:31 +0200, Cryolitia PukNgae via B4 Relay wrote: > > From: Cryolitia PukNgae > > - int param_array_set(const char *val, const struct kernel_param *kp); > - int param_array_get(char *buffer, const struct kernel_param *kp); > - void param_array_free(void *arg); > > It would be helpful for the new module param we designed in > snd_usb_audio, in order to run additional custom codes when params > are set in runtime, and re-use the extisted codes in param.c > > Signed-off-by: Cryolitia PukNgae Can we do just like below? static int param_set_quirkp(const char *val, const struct kernel_param *kp) { guard(mutex)(&quirk_flags_mutex); return param_set_charp(val, kp); } static const struct kernel_param_ops param_ops_quirkp = { .set = param_set_quirkp, .get = param_get_charp, .free = param_free_charp, }; #define param_check_quirkp param_check_charp modules_param_parray(quirk_flags, quirkp, NULL, 0644); Then mutex is locked at each time a parameter is set. Optionally, the string value can be verified in param_set_quirkp() before passing to param_set_charp(), too. thanks, Takashi