From: Jonathan Corbet <corbet@lwn.net>
To: Anish Dabhane <anishdabhane71@gmail.com>,
skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev
Cc: Anish Dabhane <anishdabhane71@gmail.com>, linux-doc@vger.kernel.org
Subject: Re: [PATCH] Fix spelling error for 'parallel'
Date: Mon, 19 May 2025 05:35:06 -0600 [thread overview]
Message-ID: <87sel0kf4l.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20250518140107.21310-1-anishdabhane71@gmail.com>
Anish Dabhane <anishdabhane71@gmail.com> writes:
> Signed-off-by: Anish Dabhane <anishdabhane71@gmail.com>
> ---
> Documentation/gpu/rfc/i915_scheduler.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/gpu/rfc/i915_scheduler.rst b/Documentation/gpu/rfc/i915_scheduler.rst
> index c237ebc024cd..2974525f0ac5 100644
> --- a/Documentation/gpu/rfc/i915_scheduler.rst
> +++ b/Documentation/gpu/rfc/i915_scheduler.rst
> @@ -26,7 +26,7 @@ i915 with the DRM scheduler is:
> which configures a slot with N contexts
> * After I915_CONTEXT_ENGINES_EXT_PARALLEL a user can submit N batches to
> a slot in a single execbuf IOCTL and the batches run on the GPU in
> - paralllel
> + parallel
> * Initially only for GuC submission but execlists can be supported if
> needed
The patch itself is fine, but a couple of nits that are worth picking:
- Always use scripts/get_maintainer.pl to see who you should send a
patch to. It should have told you to include the DRM maintainers on
this one, since they generally handle their own docs.
- It is also a good idea to look at patches for the subsystem in
question and match their subject-line style. In this case you would
see examples like:
> 0454a490bdeb drm/doc/rfc: i915 new parallel submission uAPI plan
> f587623b78ff drm/doc/rfc: i915 GuC submission / DRM scheduler
- Some maintainers will never accept patches with empty changelog text.
For a patch like this, none of these are enough to ask you to resend,
but issues like that will get in your way for future work.
I've applied it, thanks for helping to make our documentation better.
jon
prev parent reply other threads:[~2025-05-19 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-18 14:01 [PATCH] Fix spelling error for 'parallel' Anish Dabhane
2025-05-19 11:35 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sel0kf4l.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=anishdabhane71@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).