From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D331EB64D7 for ; Wed, 21 Jun 2023 05:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229659AbjFUF3U (ORCPT ); Wed, 21 Jun 2023 01:29:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjFUF3Q (ORCPT ); Wed, 21 Jun 2023 01:29:16 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52DBB10E6; Tue, 20 Jun 2023 22:28:52 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DD923218E5; Wed, 21 Jun 2023 05:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1687325330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9zyM/doTEDKZbW/dtNnMrjF7ydlOovCExA/UYr2bJ+0=; b=Lp+Qoq8eyyndQfFSN9kaO8Abre31ZhmMpXWbLBRwl1RDQWIHJD3J9pQI++6J5b6C2/1ctI 6uMXPPyXP+aS0zZfe2sIyvS1G620BKIfHCbqBg6/lyAvuRE6XRaGOIX0PthCj5wuUNvq45 Nizga2fEtAMDky8xxkXl/sa/QdPQvCk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1687325330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9zyM/doTEDKZbW/dtNnMrjF7ydlOovCExA/UYr2bJ+0=; b=Q+wYsoJI83FpAhoaIUZGWs44NbUYF+3a3vUdGm/+p83vibkSeAf4xIEWK+Akp+CZH7uJLz bmh6+Z9x67TcSTAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9CD4813A20; Wed, 21 Jun 2023 05:28:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oUwYJZKKkmTJCQAAMHmgww (envelope-from ); Wed, 21 Jun 2023 05:28:50 +0000 Date: Wed, 21 Jun 2023 07:28:50 +0200 Message-ID: <87v8fhqt7x.wl-tiwai@suse.de> From: Takashi Iwai To: Srinivas Kandagatla Cc: vkoul@kernel.org, broonie@kernel.org, tiwai@suse.com, corbet@lwn.net, alsa-devel@alsa-project.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, quic_plai@quicinc.com, quic_mohs@quicinc.com Subject: Re: [PATCH v3] ALSA: compress: allow setting codec params after next track In-Reply-To: <20230619092805.21649-1-srinivas.kandagatla@linaro.org> References: <20230619092805.21649-1-srinivas.kandagatla@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, 19 Jun 2023 11:28:05 +0200, Srinivas Kandagatla wrote: > > For gapless playback it is possible that each track can have different > codec profile with same decoder, for example we have WMA album, > we may have different tracks as WMA v9, WMA v10 and so on > > Or if DSP's like QDSP have abililty to switch decoders on single stream > for each track, then this call could be used to set new codec parameters. > > Existing code does not allow to change this profile while doing gapless > playback. > > Reuse existing SNDRV_COMPRESS_SET_PARAMS to set this new track params along > some additional checks to enforce proper state machine. > > With this new changes now the user can call SNDRV_COMPRESS_SET_PARAMS > anytime after setting next track and additional check in write should > also ensure that params are set before writing new data. > > Signed-off-by: Srinivas Kandagatla > --- > Changes since v2: > simplified the logic to allow set_params and udated the documentation accordingly Applied now. Thanks. Takashi