[PATCH] docs: filesystems: add fs/open.c to api-summary

[PATCH] docs: filesystems: add fs/open.c to api-summary

[Randy Dunlap]

Include fs/open.c in filesystems/api-summary.rst to provide its
exported APIs.

Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org

 Documentation/filesystems/api-summary.rst |    3 +++
 1 file changed, 3 insertions(+)

--- linux-next-20251219.orig/Documentation/filesystems/api-summary.rst
+++ linux-next-20251219/Documentation/filesystems/api-summary.rst
@@ -56,6 +56,9 @@ Other Functions
 .. kernel-doc:: fs/namei.c
    :export:
 
+.. kernel-doc:: fs/open.c
+   :export:
+
 .. kernel-doc:: block/bio.c
    :export:
 

Re: [PATCH] docs: filesystems: add fs/open.c to api-summary

[Christian Brauner]

On Sun, Jan 04, 2026 at 12:45:30PM -0800, Randy Dunlap wrote:
> Include fs/open.c in filesystems/api-summary.rst to provide its
> exported APIs.
> 
> Suggested-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---

Reviewed-by: Christian Brauner <brauner@kernel.org>

Re: [PATCH] docs: filesystems: add fs/open.c to api-summary

[Jonathan Corbet]

Randy Dunlap <rdunlap@infradead.org> writes:

> Include fs/open.c in filesystems/api-summary.rst to provide its
> exported APIs.
>
> Suggested-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: linux-fsdevel@vger.kernel.org
>
>  Documentation/filesystems/api-summary.rst |    3 +++
>  1 file changed, 3 insertions(+)
>
> --- linux-next-20251219.orig/Documentation/filesystems/api-summary.rst
> +++ linux-next-20251219/Documentation/filesystems/api-summary.rst
> @@ -56,6 +56,9 @@ Other Functions
>  .. kernel-doc:: fs/namei.c
>     :export:
>  
> +.. kernel-doc:: fs/open.c
> +   :export:
> +

So I've applied this, but it does add a couple of new warnings:

  Documentation/filesystems/api-summary:59: ./fs/open.c:1157: WARNING: Inline emphasis start-string without end-string. [docutils]
  Documentation/filesystems/api-summary:59: ./fs/open.c:1147: ERROR: Unknown target name: "o". [docutils]

It would be nice to get those fixed up.

Thanks,

jon

Re: [PATCH] docs: filesystems: add fs/open.c to api-summary

[Randy Dunlap]

On 1/16/26 10:40 AM, Jonathan Corbet wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
> 
>> Include fs/open.c in filesystems/api-summary.rst to provide its
>> exported APIs.
>>
>> Suggested-by: Matthew Wilcox <willy@infradead.org>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> ---
>> Cc: Jonathan Corbet <corbet@lwn.net>
>> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
>> Cc: Christian Brauner <brauner@kernel.org>
>> Cc: linux-fsdevel@vger.kernel.org
>>
>>  Documentation/filesystems/api-summary.rst |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> --- linux-next-20251219.orig/Documentation/filesystems/api-summary.rst
>> +++ linux-next-20251219/Documentation/filesystems/api-summary.rst
>> @@ -56,6 +56,9 @@ Other Functions
>>  .. kernel-doc:: fs/namei.c
>>     :export:
>>  
>> +.. kernel-doc:: fs/open.c
>> +   :export:
>> +
> 
> So I've applied this, but it does add a couple of new warnings:
> 
>   Documentation/filesystems/api-summary:59: ./fs/open.c:1157: WARNING: Inline emphasis start-string without end-string. [docutils]
>   Documentation/filesystems/api-summary:59: ./fs/open.c:1147: ERROR: Unknown target name: "o". [docutils]
> 
> It would be nice to get those fixed up.

Will do. Seems like I tweaked those already. I'll check.

thanks.
-- 
~Randy

Re: [PATCH] docs: filesystems: add fs/open.c to api-summary

[Randy Dunlap]

On 1/16/26 10:46 AM, Randy Dunlap wrote:
> 
> 
> On 1/16/26 10:40 AM, Jonathan Corbet wrote:
>> Randy Dunlap <rdunlap@infradead.org> writes:
>>
>>> Include fs/open.c in filesystems/api-summary.rst to provide its
>>> exported APIs.
>>>
>>> Suggested-by: Matthew Wilcox <willy@infradead.org>
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> ---
>>> Cc: Jonathan Corbet <corbet@lwn.net>
>>> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
>>> Cc: Christian Brauner <brauner@kernel.org>
>>> Cc: linux-fsdevel@vger.kernel.org
>>>
>>>  Documentation/filesystems/api-summary.rst |    3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> --- linux-next-20251219.orig/Documentation/filesystems/api-summary.rst
>>> +++ linux-next-20251219/Documentation/filesystems/api-summary.rst
>>> @@ -56,6 +56,9 @@ Other Functions
>>>  .. kernel-doc:: fs/namei.c
>>>     :export:
>>>  
>>> +.. kernel-doc:: fs/open.c
>>> +   :export:
>>> +
>>
>> So I've applied this, but it does add a couple of new warnings:
>>
>>   Documentation/filesystems/api-summary:59: ./fs/open.c:1157: WARNING: Inline emphasis start-string without end-string. [docutils]
>>   Documentation/filesystems/api-summary:59: ./fs/open.c:1147: ERROR: Unknown target name: "o". [docutils]
>>
>> It would be nice to get those fixed up.
> 
> Will do. Seems like I tweaked those already. I'll check.
> 
> thanks.

Seems I was confused with fs/namei.c, where I see similar warnings.
I don't see those warnings in fs/open.c.

I'm using today's linux-next tree, where the latest change to
fs/open.c is:
ommit 750d2f1f7b5c
Author: Al Viro <viro@zeniv.linux.org.uk>
Date:   Sun Dec 14 03:13:59 2025 -0500
    chroot(2): switch to CLASS(filename)

Do you have something later (newer) than that?

Also, at fs/open.c lines 1147-1157, I don't see anything that would
cause docs warnings.

Ideas?

thanks.
-- 
~Randy

Re: [PATCH] docs: filesystems: add fs/open.c to api-summary

[Jonathan Corbet]

Randy Dunlap <rdunlap@infradead.org> writes:

> Seems I was confused with fs/namei.c, where I see similar warnings.
> I don't see those warnings in fs/open.c.
>
> I'm using today's linux-next tree, where the latest change to
> fs/open.c is:
> ommit 750d2f1f7b5c
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date:   Sun Dec 14 03:13:59 2025 -0500
>     chroot(2): switch to CLASS(filename)
>
> Do you have something later (newer) than that?
>
> Also, at fs/open.c lines 1147-1157, I don't see anything that would
> cause docs warnings.

No, docs-next is older - based on -rc2.  It seems that linux-next has
significantly thrashed thing there, and the offending function
(dentry_create()) moved to namei.c...

jon

Re: [PATCH] docs: filesystems: add fs/open.c to api-summary

[Randy Dunlap]

On 1/16/26 11:27 AM, Jonathan Corbet wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
> 
>> Seems I was confused with fs/namei.c, where I see similar warnings.
>> I don't see those warnings in fs/open.c.
>>
>> I'm using today's linux-next tree, where the latest change to
>> fs/open.c is:
>> ommit 750d2f1f7b5c
>> Author: Al Viro <viro@zeniv.linux.org.uk>
>> Date:   Sun Dec 14 03:13:59 2025 -0500
>>     chroot(2): switch to CLASS(filename)
>>
>> Do you have something later (newer) than that?
>>
>> Also, at fs/open.c lines 1147-1157, I don't see anything that would
>> cause docs warnings.
> 
> No, docs-next is older - based on -rc2.  It seems that linux-next has
> significantly thrashed thing there, and the offending function
> (dentry_create()) moved to namei.c...

2 patches have been sent for these warnings:

2025-12-19:
https://lore.kernel.org/all/20251219-dentry-inline-v2-1-c074b5bfb3a6@gmail.com/

2025-12-31:
https://lore.kernel.org/all/20251231153851.7523-1-krishnagopi487@gmail.com/


-- 
~Randy

Re: [PATCH] docs: filesystems: add fs/open.c to api-summary

[Randy Dunlap]

On 1/16/26 2:24 PM, Randy Dunlap wrote:
> 
> 
> On 1/16/26 11:27 AM, Jonathan Corbet wrote:
>> Randy Dunlap <rdunlap@infradead.org> writes:
>>
>>> Seems I was confused with fs/namei.c, where I see similar warnings.
>>> I don't see those warnings in fs/open.c.
>>>
>>> I'm using today's linux-next tree, where the latest change to
>>> fs/open.c is:
>>> ommit 750d2f1f7b5c
>>> Author: Al Viro <viro@zeniv.linux.org.uk>
>>> Date:   Sun Dec 14 03:13:59 2025 -0500
>>>     chroot(2): switch to CLASS(filename)
>>>
>>> Do you have something later (newer) than that?
>>>
>>> Also, at fs/open.c lines 1147-1157, I don't see anything that would
>>> cause docs warnings.
>>
>> No, docs-next is older - based on -rc2.  It seems that linux-next has
>> significantly thrashed thing there, and the offending function
>> (dentry_create()) moved to namei.c...
> 
> 2 patches have been sent for these warnings:
> 
> 2025-12-19:
> https://lore.kernel.org/all/20251219-dentry-inline-v2-1-c074b5bfb3a6@gmail.com/
> 
> 2025-12-31:
> https://lore.kernel.org/all/20251231153851.7523-1-krishnagopi487@gmail.com/
> 

Oh, so a third option was merged.
https://lore.kernel.org/all/20260118110401.2651-1-jaybenjaminwinston@gmail.com/

I only care for backporting reasons:
https://lore.kernel.org/linux-doc/202601211140.pWd7ohTh-lkp@intel.com/

since I am being blamed for some new warnings and these patches fix them (except
that they have been moved from fs/open.c to fs/namei.c).


-- 
~Randy