From: Jonathan Corbet <corbet@lwn.net>
To: Carlos Bilbao <carlos.bilbao@amd.com>,
ojeda@kernel.org, akiyks@gmail.com, jani.nikula@linux.intel.com,
rdunlap@infradead.org
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
konstantin@linuxfoundation.org,
Carlos Bilbao <carlos.bilbao@amd.com>
Subject: Re: [PATCH v5 0/2] docs: Integrate rustdoc into Rust documentation
Date: Mon, 02 Jan 2023 16:53:58 -0700 [thread overview]
Message-ID: <87wn64fq7d.fsf@meer.lwn.net> (raw)
In-Reply-To: <20221228174623.144199-1-carlos.bilbao@amd.com>
Carlos Bilbao <carlos.bilbao@amd.com> writes:
> Include HTML output generated with rustdoc into the Linux kernel
> documentation on Rust.
>
> Carlos Bilbao:
> docs: Move rustdoc output, cross-reference it
> docs: Integrate rustdoc generation into htmldocs
OK, so I just gave this a try...
- It forces the generation of a kernel configuration, something that the
docs build has never done until now. What are our changes of
eliminating that?
- It did a bunch of other building, starting with objtool - again, never
needed for the docs build before.
In the end, it died with:
> BINDGEN rust/bindings/bindings_generated.rs
> Failed to run rustfmt: No such file or directory (os error 2) (non-fatal, continuing)
> BINDGEN rust/bindings/bindings_helpers_generated.rs
> error: Found argument '--blacklist-type' which wasn't expected, or isn't valid in this context
>
> Did you mean '--blocklist-type'?
Perhaps this is because I ignored the warnings about my Rust toolchain
being too new? (Rust 1.65.0, bindgen 0.63.0). I get that only one
version is really supported, but it would be nice to fail a bit more
gracefully if at all possible.
Anyway, I've unapplied these for now; thoughts on all this?
Thanks,
jon
next prev parent reply other threads:[~2023-01-02 23:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 17:30 [PATCH v4 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
2022-12-07 17:30 ` [PATCH v4 1/2] docs: Move rustdoc output, cross-reference it Carlos Bilbao
2022-12-07 20:46 ` Jani Nikula
2022-12-07 22:57 ` Akira Yokosawa
2022-12-28 17:43 ` Carlos Bilbao
2022-12-07 17:30 ` [PATCH v4 2/2] docs: Integrate rustdoc generation into htmldocs Carlos Bilbao
2022-12-28 17:46 ` [PATCH v5 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
2022-12-28 17:46 ` [PATCH v5 1/2] docs: Move rustdoc output, cross-reference it Carlos Bilbao
2022-12-28 17:46 ` [PATCH v5 2/2] docs: Integrate rustdoc generation into htmldocs Carlos Bilbao
2023-01-02 23:53 ` Jonathan Corbet [this message]
2023-01-03 14:06 ` [PATCH v5 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
2023-01-04 0:20 ` Jonathan Corbet
2023-01-03 14:19 ` Miguel Ojeda
2023-01-04 0:25 ` Jonathan Corbet
2023-01-04 1:55 ` Miguel Ojeda
2023-01-04 14:53 ` Jonathan Corbet
2023-01-04 19:54 ` Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn64fq7d.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akiyks@gmail.com \
--cc=carlos.bilbao@amd.com \
--cc=jani.nikula@linux.intel.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).