From: Jonathan Corbet <corbet@lwn.net>
To: Akira Yokosawa <akiyks@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-pm@vger.kernel.org, linux-doc@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH -pm] docs: driver-api/thermal/intel_dptf: Include isonum.txt
Date: Fri, 01 Apr 2022 08:41:04 -0600 [thread overview]
Message-ID: <87y20oyigv.fsf@meer.lwn.net> (raw)
In-Reply-To: <e06542af-aa8b-0885-37a3-bb7bc5fafa1e@gmail.com>
Akira Yokosawa <akiyks@gmail.com> writes:
> For the "|copy|" substitution to work, need to include isonum.txt.
>
> Fixes: 16c02447f3e1 ("Documentation: thermal: DPTF Documentation")
> Reported by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-doc@vger.kernel.org
> ---
> Hi,
>
> This fixes a doc build warning reported by Randy at
> https://lore.kernel.org/r/73d98132-1d08-ef29-edb7-9e062b9154b8@infradead.org/.
>
> Thanks, Akira
> --
> Documentation/driver-api/thermal/intel_dptf.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/driver-api/thermal/intel_dptf.rst b/Documentation/driver-api/thermal/intel_dptf.rst
> index 96668dca753a..2df82719c5be 100644
> --- a/Documentation/driver-api/thermal/intel_dptf.rst
> +++ b/Documentation/driver-api/thermal/intel_dptf.rst
> @@ -1,5 +1,7 @@
> .. SPDX-License-Identifier: GPL-2.0
>
> +.. include:: <isonum.txt>
> +
Interesting...I don't think that was always necessary.
I have to ask, though: is this worth it? It adds up to a fair amount of
clutter to get one symbol - © - that can also just be inserted directly
if we really think we need it. I'd vote for doing a global s/|copy|/©/
instead.
Thanks,
jon
next prev parent reply other threads:[~2022-04-01 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 5:57 [PATCH -pm] docs: driver-api/thermal/intel_dptf: Include isonum.txt Akira Yokosawa
2022-04-01 6:04 ` Randy Dunlap
2022-04-01 14:41 ` Jonathan Corbet [this message]
2022-04-01 23:24 ` Akira Yokosawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y20oyigv.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akiyks@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).