From: Thomas Gleixner <tglx@linutronix.de>
To: lakshmi.sowjanya.d@intel.com, jstultz@google.com,
giometti@enneenne.com, corbet@lwn.net,
linux-kernel@vger.kernel.org
Cc: x86@kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
andriy.shevchenko@linux.intel.com, eddie.dong@intel.com,
christopher.s.hall@intel.com, jesse.brandeburg@intel.com,
davem@davemloft.net, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com, perex@perex.cz,
linux-sound@vger.kernel.org, anthony.l.nguyen@intel.com,
peter.hilber@opensynergy.com, pandith.n@intel.com,
mallikarjunappa.sangannavar@intel.com,
subramanian.mohan@intel.com, basavaraj.goudar@intel.com,
thejesh.reddy.t.r@intel.com, lakshmi.sowjanya.d@intel.com
Subject: Re: [PATCH v5 01/11] x86/tsc: Add base clock properties in clocksource structure
Date: Wed, 20 Mar 2024 12:30:52 +0100 [thread overview]
Message-ID: <87zfutgmxf.ffs@tglx> (raw)
In-Reply-To: <875xxhi1ty.ffs@tglx>
On Wed, Mar 20 2024 at 12:23, Thomas Gleixner wrote:
> On Tue, Mar 19 2024 at 18:35, lakshmi.sowjanya.d@intel.com wrote:
>> From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
>>
>> Add base clock hardware abstraction in clocksource structure.
>>
>> Add clocksource ID for x86 ART(Always Running Timer).
>
> This change log tells the WHAT but not the WHY. You have to add context
> and explanation WHY this change is required and why it makes sense.
>
> Also I think this should be ordered differently:
>
> 1) Add the clocksource_base struct and provide the infrastructure in
> get_device_system_crosststamp()
>
> 2) Make TSC/ART use it
2a) Remove the art to tsc conversion in drivers
2b) Remove art to tsc
> 3) Add the realtime muck
>
> Thanks,
>
> tglx
next prev parent reply other threads:[~2024-03-20 11:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 13:05 [PATCH v5 00/11] Add support for Intel PPS Generator lakshmi.sowjanya.d
2024-03-19 13:05 ` [PATCH v5 01/11] x86/tsc: Add base clock properties in clocksource structure lakshmi.sowjanya.d
2024-03-20 11:23 ` Thomas Gleixner
2024-03-20 11:30 ` Thomas Gleixner [this message]
2024-03-19 13:05 ` [PATCH v5 02/11] timekeeping: Add function to convert realtime to base clock lakshmi.sowjanya.d
2024-03-19 22:29 ` John Stultz
2024-03-20 11:29 ` Thomas Gleixner
2024-03-21 14:53 ` Thomas Gleixner
2024-04-01 13:07 ` D, Lakshmi Sowjanya
2024-03-19 13:05 ` [PATCH v5 03/11] e1000e: remove convert_art_to_tsc() lakshmi.sowjanya.d
2024-03-19 13:05 ` [PATCH v5 04/11] igc: " lakshmi.sowjanya.d
2024-03-19 13:05 ` [PATCH v5 05/11] stmmac: intel: " lakshmi.sowjanya.d
2024-03-19 13:05 ` [PATCH v5 06/11] ALSA: hda: " lakshmi.sowjanya.d
2024-03-19 13:05 ` [PATCH v5 07/11] ice/ptp: " lakshmi.sowjanya.d
2024-03-19 13:05 ` [PATCH v5 08/11] x86/tsc: Remove art to tsc conversion functions which are obsolete lakshmi.sowjanya.d
2024-03-19 13:05 ` [PATCH v5 09/11] pps: generators: Add PPS Generator TIO Driver lakshmi.sowjanya.d
2024-03-20 16:17 ` Rodolfo Giometti
2024-03-19 13:05 ` [PATCH v5 10/11] Documentation: driver-api: pps: Add Intel Timed I/O PPS generator lakshmi.sowjanya.d
2024-03-20 16:18 ` Rodolfo Giometti
2024-03-19 13:05 ` [PATCH v5 11/11] ABI: pps: Add ABI documentation for Intel TIO lakshmi.sowjanya.d
2024-03-20 16:09 ` Simon Horman
2024-03-19 22:48 ` [Intel-wired-lan] [PATCH v5 00/11] Add support for Intel PPS Generator Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfutgmxf.ffs@tglx \
--to=tglx@linutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=basavaraj.goudar@intel.com \
--cc=christopher.s.hall@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=eddie.dong@intel.com \
--cc=giometti@enneenne.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=joabreu@synopsys.com \
--cc=jstultz@google.com \
--cc=lakshmi.sowjanya.d@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pandith.n@intel.com \
--cc=perex@perex.cz \
--cc=peter.hilber@opensynergy.com \
--cc=subramanian.mohan@intel.com \
--cc=thejesh.reddy.t.r@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).