Linux Documentation
 help / color / mirror / Atom feed
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Ahmad Byagowi <ahmadexp@gmail.com>,
	netdev@vger.kernel.org, andi.shyti@kernel.org
Cc: andrew+netdev@lunn.ch, corbet@lwn.net, davem@davemloft.net,
	edumazet@kernel.org, horms@kernel.org, jiri@resnulli.us,
	kuba@kernel.org, linux-doc@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	pabeni@redhat.com, rdunlap@infradead.org,
	richardcochran@gmail.com, skhan@linuxfoundation.org
Subject: Re: [PATCH net-next v3 3/3] ptp: ocp: support the WiWi revision 02 Time Card
Date: Thu, 19 Nov 2026 18:44:38 +0000	[thread overview]
Message-ID: <890ef941-0c52-4e3c-9fce-70b11fd1b198@linux.dev> (raw)
In-Reply-To: <20261116-wiwi-v3-87afa10a8-3-ahmadexp@gmail.com>

On 16/11/2026 18:20, Ahmad Byagowi wrote:
> Match WiWi 2163:1008, subsystem 10ee:0007, without a class filter.
> Resolve WiWi devices against the static PCI table so a dynamic ID
> cannot substitute an unrelated resource layout. NetTimeLogic uses the PCI
> Revision ID for incompatible interface changes. Revision 02 identifies
> the LitePCIe/MSI-X interface; the Xilinx subsystem ID and FPGA build
> number do not identify the register interface. Reject unknown revisions
> and check BAR0 and the MSI-X layout before accessing FPGA registers.
> Do not probe a CoreList or require exact versions of individual cores.
> 
> Report the full 32-bit image ID as the running firmware build. Derive
> signal and frequency capabilities from the supported revision, not the
> legacy FB build-number thresholds. This ID does not identify the boot
> slot. Retain legacy version reporting on other cards.
> 
> WiWi shares the peripheral resource table used by the existing Celestica
> entry (18d4:1008), not its PCI addressing and interrupt scheme.
> For WiWi only, translate peripheral offsets by 0x02000000 and interrupt
> inputs by 32.

Let's not do this magic. If addressing and interrupt schema differ then
it means another resource table. If there is a way to make it flexible,
let's do it compile-time only.

Use aligned 32-bit UART I/O and typed XIIC platform
> data, sharing the EEPROM list but not casting another controller's data.
> Do not expose an unvalidated second GNSS UART or PPS output source.

Why it's not a problem for ADVA and ART boards?

> Keep the external SMA PPS2 input. The PCI revision identifies the host
> interface, not optional board wiring. Use hardware selector values for
> WiWi DPLL routing; preserve the existing behavior on other boards.
> 
> Enable the three UART and XIIC inputs during probe. Reject attempts to
> arm a timestamper or generator with -EAGAIN until the timing gate write
> has been flushed. This avoids relying on FPGA replay of a pulse caused
> by a userspace request made while the gate was closed.

Why is it a problem for new revision but not for the older ones?

> 
> Do not register the WiWi SPI flash controller or enable its interrupt.
> This prevents the driver from exposing raw MTD access to the golden
> image. Reject devlink flash as well. The update format and controller
> support are not validated; read access via MTD is intentionally lost.

Is there a process to actually enable flash upgrades?

      parent reply	other threads:[~2026-11-19 18:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 18:20 [PATCH net-next v3 0/3] ptp: ocp: support the WiWi production Time Card Ahmad Byagowi
2026-11-16 18:20 ` [PATCH net-next v3 3/3] ptp: ocp: support the WiWi revision 02 " Ahmad Byagowi
2026-11-18 18:22   ` netdev-bot+sashiko
2026-11-18 20:05     ` Ahmad Byagowi
2026-11-19 18:44   ` Vadim Fedorenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=890ef941-0c52-4e3c-9fce-70b11fd1b198@linux.dev \
    --to=vadim.fedorenko@linux.dev \
    --cc=ahmadexp@gmail.com \
    --cc=andi.shyti@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=richardcochran@gmail.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox